From: Jan Hubicka <hubicka@ucw.cz>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Iain Sandoe <developer@sandoe-acoustics.co.uk>,
Jan Hubicka <hubicka@ucw.cz>,
Hans-Peter Nilsson <hans-peter.nilsson@axis.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFA:] fix breakage with "Update testsuite to run with slim LTO"
Date: Fri, 21 Oct 2011 16:20:00 -0000 [thread overview]
Message-ID: <20111021154414.GC18476@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <yddk47yeeww.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
> If running the gnat.dg testsuite, lib/gcc-dg.exp is now calling
> check_linker_plugin_available early, which ultimately calls
> ${tool}_target_compile. For all languages but Ada,
> ${tool}_target_compile can compile .c files just fine, but
> gnat_target_compile (which uses gnatmake) cannot, so it falls back to
> directly calling gcc_target_compile in that case. gcc_target_compile
> relies on GCC_UNDER_TEST being set, which in this case hasn't yet
> happened, thus the error.
>
> My solution (a hack, actually) is to move the initialization of
> GCC_UNDER_TEST in gcc-dg.exp before the calls to
> check_linker_plugin_available. x86_64-unknown-linux-gnu testing in
> progress, will commit once that's finished.
Oops, I was under impression that GNAT testsuite is not really using dejagnu
lib so I did not expected a change here.
Thanks for fixing that!
I also noticed that tests scanning output of late optimization passes are
now getting UNRESOLVED state with slim LTO. We don't really lose coverage
here because we test fat LTO with the other compilation, but probably easiest
is to enfore fat LTO all the time.
Does the following seem resonable?
Honza
* gcc.dg/torture/pta-ptrarith-1.c: Force fat LTO.
* gcc.dg/torture/pta-ptrarith-2.c: Likewise.
* gcc.dg/torture/pr23821.c: Likewise.
* gcc.dg/torture/pta-ptrarith-3.c: Likewise.
* gcc.dg/torture/pr45704.c: Likewise.
* gcc.dg/torture/pr50472.c: Likewise.
* gcc.dg/torture/ipa-pta-1.c: Likewise.
* gcc.dg/torture/pta-callused-1.c: Likewise.
* gcc.dg/torture/pr39074-2.c: Likewise.
* gcc.dg/torture/pr39074.c: Likewise.
* gcc.dg/torture/pr42898-2.c: Likewise.
* gcc.dg/torture/pr42898.c: Likewise.
* gcc.dg/torture/pta-escape-1.c: Likewise.
* gcc.dg/torture/ssa-pta-fn-1.c: Likewise.
Index: gcc.dg/torture/pta-ptrarith-1.c
===================================================================
*** gcc.dg/torture/pta-ptrarith-1.c (revision 180289)
--- gcc.dg/torture/pta-ptrarith-1.c (working copy)
***************
*** 1,5 ****
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
struct Foo {
--- 1,5 ----
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
struct Foo {
Index: gcc.dg/torture/pta-ptrarith-2.c
===================================================================
*** gcc.dg/torture/pta-ptrarith-2.c (revision 180289)
--- gcc.dg/torture/pta-ptrarith-2.c (working copy)
***************
*** 1,5 ****
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
struct Foo {
--- 1,5 ----
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
struct Foo {
Index: gcc.dg/torture/pr23821.c
===================================================================
*** gcc.dg/torture/pr23821.c (revision 180289)
--- gcc.dg/torture/pr23821.c (working copy)
***************
*** 3,9 ****
/* At -O1 DOM threads a jump in a non-optimal way which leads to
the bogus propagation. */
/* { dg-skip-if "" { *-*-* } { "-O1" } { "" } } */
! /* { dg-options "-fdump-tree-ivcanon-details" } */
int a[199];
--- 3,9 ----
/* At -O1 DOM threads a jump in a non-optimal way which leads to
the bogus propagation. */
/* { dg-skip-if "" { *-*-* } { "-O1" } { "" } } */
! /* { dg-options "-fdump-tree-ivcanon-details -ffat-lto-objects" } */
int a[199];
Index: gcc.dg/torture/pta-ptrarith-3.c
===================================================================
*** gcc.dg/torture/pta-ptrarith-3.c (revision 180289)
--- gcc.dg/torture/pta-ptrarith-3.c (working copy)
***************
*** 1,5 ****
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
extern void abort (void);
--- 1,5 ----
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
extern void abort (void);
Index: gcc.dg/torture/pr45704.c
===================================================================
*** gcc.dg/torture/pr45704.c (revision 180289)
--- gcc.dg/torture/pr45704.c (working copy)
***************
*** 1,5 ****
/* { dg-do compile } */
! /* { dg-options "-fdump-tree-optimized" } */
struct st {
int ptr;
--- 1,5 ----
/* { dg-do compile } */
! /* { dg-options "-fdump-tree-optimized -ffat-lto-objects" } */
struct st {
int ptr;
Index: gcc.dg/torture/pr50472.c
===================================================================
*** gcc.dg/torture/pr50472.c (revision 180289)
--- gcc.dg/torture/pr50472.c (working copy)
***************
*** 1,5 ****
/* { dg-do compile } */
! /* { dg-options "-fdump-tree-optimized" } */
static const unsigned int foo = 1;
unsigned int test( void )
--- 1,5 ----
/* { dg-do compile } */
! /* { dg-options "-fdump-tree-optimized -ffat-lto-objects" } */
static const unsigned int foo = 1;
unsigned int test( void )
Index: gcc.dg/torture/ipa-pta-1.c
===================================================================
*** gcc.dg/torture/ipa-pta-1.c (revision 180289)
--- gcc.dg/torture/ipa-pta-1.c (working copy)
***************
*** 1,5 ****
/* { dg-do compile { target { nonpic } } } */
! /* { dg-options "-fipa-pta -fdump-ipa-pta" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
struct X { char x; char y; };
--- 1,5 ----
/* { dg-do compile { target { nonpic } } } */
! /* { dg-options "-fipa-pta -fdump-ipa-pta -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
struct X { char x; char y; };
Index: gcc.dg/torture/pta-callused-1.c
===================================================================
*** gcc.dg/torture/pta-callused-1.c (revision 180289)
--- gcc.dg/torture/pta-callused-1.c (working copy)
***************
*** 1,5 ****
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
volatile int i;
--- 1,5 ----
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
volatile int i;
Index: gcc.dg/torture/pr39074-2.c
===================================================================
*** gcc.dg/torture/pr39074-2.c (revision 180289)
--- gcc.dg/torture/pr39074-2.c (working copy)
***************
*** 1,6 ****
/* { dg-do run } */
/* { dg-require-effective-target stdint_types } */
! /* { dg-options "-fdump-tree-alias" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
#include <stdint.h>
--- 1,6 ----
/* { dg-do run } */
/* { dg-require-effective-target stdint_types } */
! /* { dg-options "-fdump-tree-alias -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
#include <stdint.h>
Index: gcc.dg/torture/pr39074.c
===================================================================
*** gcc.dg/torture/pr39074.c (revision 180289)
--- gcc.dg/torture/pr39074.c (working copy)
***************
*** 1,5 ****
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
typedef __PTRDIFF_TYPE__ intptr_t;
--- 1,5 ----
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
typedef __PTRDIFF_TYPE__ intptr_t;
Index: gcc.dg/torture/pr42898-2.c
===================================================================
*** gcc.dg/torture/pr42898-2.c (revision 180289)
--- gcc.dg/torture/pr42898-2.c (working copy)
***************
*** 1,5 ****
/* { dg-do compile } */
! /* { dg-options "-fdump-tree-optimized" } */
struct hardware {
int parm1:8;
--- 1,5 ----
/* { dg-do compile } */
! /* { dg-options "-fdump-tree-optimized -ffat-lto-objects" } */
struct hardware {
int parm1:8;
Index: gcc.dg/torture/pr42898.c
===================================================================
*** gcc.dg/torture/pr42898.c (revision 180289)
--- gcc.dg/torture/pr42898.c (working copy)
***************
*** 1,5 ****
/* { dg-do compile } */
! /* { dg-options "-fdump-tree-optimized" } */
struct hardware {
int parm1:8;
--- 1,5 ----
/* { dg-do compile } */
! /* { dg-options "-fdump-tree-optimized -ffat-lto-objects" } */
struct hardware {
int parm1:8;
Index: gcc.dg/torture/pta-escape-1.c
===================================================================
*** gcc.dg/torture/pta-escape-1.c (revision 180289)
--- gcc.dg/torture/pta-escape-1.c (working copy)
***************
*** 1,5 ****
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
int *p;
--- 1,5 ----
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
int *p;
Index: gcc.dg/torture/ssa-pta-fn-1.c
===================================================================
*** gcc.dg/torture/ssa-pta-fn-1.c (revision 180289)
--- gcc.dg/torture/ssa-pta-fn-1.c (working copy)
***************
*** 1,5 ****
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
extern void abort (void);
--- 1,5 ----
/* { dg-do run } */
! /* { dg-options "-fdump-tree-alias -ffat-lto-objects" } */
/* { dg-skip-if "" { *-*-* } { "-O0" } { "" } } */
extern void abort (void);
next prev parent reply other threads:[~2011-10-21 15:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 17:54 Update testsuite to run with slim LTO Jan Hubicka
2011-09-30 14:56 ` Diego Novillo
2011-10-20 19:34 ` Breakage with "Update testsuite to run with slim LTO" Hans-Peter Nilsson
2011-10-20 19:53 ` Andi Kleen
2011-10-21 0:39 ` Jan Hubicka
2011-10-21 5:22 ` [RFA:] fix breakage " Hans-Peter Nilsson
2011-10-21 9:58 ` Jan Hubicka
2011-10-21 12:23 ` Iain Sandoe
2011-10-21 12:35 ` Rainer Orth
2011-10-21 16:20 ` Jan Hubicka [this message]
2011-10-21 17:40 ` Hans-Peter Nilsson
2011-10-21 18:52 ` Jan Hubicka
2011-10-21 19:56 ` Hans-Peter Nilsson
2011-10-24 12:08 ` Richard Guenther
2011-10-28 14:59 ` ping: [RFA:] testsuite infrastructure for options implied by dg-final methods Hans-Peter Nilsson
2011-11-04 13:56 ` ping*2: " Hans-Peter Nilsson
2011-11-04 17:05 ` Mike Stump
2011-11-04 17:54 ` Hans-Peter Nilsson
2011-11-04 18:14 ` Mike Stump
2011-11-04 18:16 ` Hans-Peter Nilsson
2023-05-03 11:16 ` Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS' (was: Update testsuite to run with slim LTO) Thomas Schwinge
2023-05-03 11:46 ` Richard Biener
2023-05-09 7:32 ` Christophe Lyon
2023-05-09 9:00 ` Testsuite: Add missing 'torture-init'/'torture-finish' around 'LTO_TORTURE_OPTIONS' usage (was: Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS') Thomas Schwinge
2023-05-09 15:17 ` Christophe Lyon
2023-05-09 19:14 ` Christophe Lyon
2023-05-10 7:51 ` Testsuite: Add 'torture-init-done', and use it to conditionalize implicit 'torture-init' (was: Testsuite: Add missing 'torture-init'/'torture-finish' around 'LTO_TORTURE_OPTIONS' usage (was: Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS')) Thomas Schwinge
2023-05-10 13:42 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021154414.GC18476@atrey.karlin.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=developer@sandoe-acoustics.co.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).