From: David Miller <davem@davemloft.net>
To: joel.sherrill@OARcorp.com
Cc: gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE
Subject: Re: serious libgcc regression added recently
Date: Thu, 03 Nov 2011 00:22:00 -0000 [thread overview]
Message-ID: <20111102.192827.347645445311137460.davem@davemloft.net> (raw)
In-Reply-To: <20111102.184352.196670434103290808.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 02 Nov 2011 18:43:52 -0400 (EDT)
> So t-softmul gets appended anyways, and this causes us to try and
> build config/sparc/lb1spc.S for the 64-bit libgcc which we should
> never do.
I tried the patch below but it just results in syntax errors in the
Makefile.
Is this the way differences between multilib cases are going to be
handled now in libgcc, with these backtick shell conditionals that (of
all things) looks at the destination directory?
What if I want to put 64-bit libraries in a different location such as
plain 'lib/' to create a 64-bit pure system or similar?
I definitely prefer how this stuff worked beforehand wherein we would
know the actual "target" we're building for and we bring in the
appropriate "target" makefile fragments based upon that "target".
Now we just seem to look at the host and essentially include every
possible target makefile that could be multilibbed out of that host.
diff --git a/libgcc/config.host b/libgcc/config.host
index 05f084b..47e0e73 100644
--- a/libgcc/config.host
+++ b/libgcc/config.host
@@ -1052,7 +1052,8 @@ sparc64-*-freebsd*|ultrasparc-*-freebsd*)
;;
sparc64-*-linux*) # 64-bit SPARC's running GNU/Linux
extra_parts="$extra_parts crtfastmath.o"
- tmake_file="${tmake_file} t-crtfm sparc/t-linux sparc/t-linux64"
+ tmake_file="${tmake_file} t-crtfm sparc/t-linux sparc/t-linux64 \
+ sparc/t-softmul"
md_unwind_header=sparc/linux-unwind.h
;;
sparc64-*-netbsd*)
diff --git a/libgcc/config/sparc/t-softmul b/libgcc/config/sparc/t-softmul
index 7142200..5489a37 100644
--- a/libgcc/config/sparc/t-softmul
+++ b/libgcc/config/sparc/t-softmul
@@ -1,2 +1,4 @@
-LIB1ASMSRC = sparc/lb1spc.S
-LIB1ASMFUNCS = _mulsi3 _divsi3 _modsi3
+LIB1ASMSRC = `if test x$$($(CC) -print-multi-os-directory) \
+ = x../lib64; then echo sparc/lb1spc.S; fi`
+LIB1ASMFUNCS = `if test x$$($(CC) -print-multi-os-directory) \
+ = x../lib64; then echo _mulsi3 _divsi3 _modsi3; fi`
next prev parent reply other threads:[~2011-11-02 23:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 20:49 David Miller
2011-11-02 22:10 ` Joel Sherrill
2011-11-02 22:52 ` David Miller
2011-11-02 23:06 ` David Miller
2011-11-03 0:22 ` David Miller [this message]
2011-11-03 0:23 ` Andrew Pinski
2011-11-03 1:25 ` David Miller
2011-11-03 0:35 ` Joseph S. Myers
2011-11-03 0:32 ` Joseph S. Myers
2011-11-03 1:51 ` David Miller
2011-11-03 3:22 ` Joseph S. Myers
2011-11-03 4:53 ` David Miller
2011-11-03 9:00 ` Paolo Bonzini
2011-11-03 9:16 ` Jakub Jelinek
2011-11-04 7:50 ` David Miller
2011-11-05 3:23 ` David Miller
2011-11-03 14:17 ` Joel Sherrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102.192827.347645445311137460.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=joel.sherrill@OARcorp.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).