From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16453 invoked by alias); 4 Nov 2011 13:48:07 -0000 Received: (qmail 16438 invoked by uid 22791); 4 Nov 2011 13:48:06 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,RDNS_NONE X-Spam-Check-By: sourceware.org Received: from Unknown (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Nov 2011 13:47:45 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id 49A4419ED2; Fri, 4 Nov 2011 14:47:38 +0100 (CET) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id u6Vkh3t1DHRP; Fri, 4 Nov 2011 14:47:37 +0100 (CET) Received: from seth.se.axis.com (seth.se.axis.com [10.0.2.172]) by anubis.se.axis.com (Postfix) with ESMTP id 2A40819ECF; Fri, 4 Nov 2011 14:47:37 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by seth.se.axis.com (Postfix) with ESMTP id 0D3763E0F2; Fri, 4 Nov 2011 14:47:37 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id pA4DlaF6030696; Fri, 4 Nov 2011 14:47:36 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id pA4Dla6n030692; Fri, 4 Nov 2011 14:47:36 +0100 Date: Fri, 04 Nov 2011 13:56:00 -0000 Message-Id: <201111041347.pA4Dla6n030692@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gcc-patches@gcc.gnu.org CC: ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net In-reply-to: <201110281434.p9SEY70I018869@ignucius.se.axis.com> (message from Hans-Peter Nilsson on Fri, 28 Oct 2011 16:34:07 +0200) Subject: ping*2: [RFA:] testsuite infrastructure for options implied by dg-final methods MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg00558.txt.bz2 Ping again, CC:ing testsuite maintainers. Honza thought this was a good idea, if that helps. > From: Hans-Peter Nilsson > Date: Fri, 28 Oct 2011 16:34:07 +0200 > Subject changed from '[RFA:] fix breakage with "Update testsuite > to run with slim LTO"' except it doesn't fix *all* breakage > introduced by that patch, only the one I observed and intended > to fix. > > > Date: Fri, 21 Oct 2011 04:29:20 +0200 > > From: Hans-Peter Nilsson > > > > Date: Fri, 21 Oct 2011 00:19:32 +0200 > > > From: Jan Hubicka > > > Yes, if we scan assembler, we likely want -fno-fat-lto-objects. > > > > > > then IIUC you need to patch *all* torture tests that use > > > > scan-assembler and scan-assembler-not. Alternatively, patch > > > > somewhere else, like not passing it if certain directives are > > > > used, like scan-assembler{,-not}. And either way, is it safe to > > > > add that option always, not just when also passing "-flto" or > > > > something? > > > > > > Hmm, some of assembler scans still works because they check for > > > presence of symbols we output anyway, but indeed, it would make more > > > sense to automatically imply -ffat-lto-object when scan-assembler > > > is used. I am not sure if my dejagnu skill as on par here however. > > > > Maybe you could make amends ;) by testing the following, which > > seems to work at least for dg-torture.exp and cris-elf/cris-sim, > > in which -ffat-lto-object is automatically added for each > > scan-assembler and scan-assembler-not test, extensible for other > > dg-final actions without polluting with checking LTO options and > > whatnot across the files. I checked (and corrected) so it also > > works when !check_effective_target_lto by commenting out the > > setting in the second chunk. > > > > gcc/testsuite: > > > > * lib/gcc-dg.exp (gcc_force_conventional_output): New global > > variable, default empty, -ffat-lto-objects for effective_target_lto. > > (gcc-dg-test-1): Add options from dg-final methods. > > * lib/scanasm.exp (scan-assembler_required_options) > > (scan-assembler-not_required_options): New procs. > > > Ok to commit? > > brgds, H-P >