From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: mikestump@comcast.net
Cc: hp@axis.com, gcc-patches@gcc.gnu.org,
ro@CeBiTec.Uni-Bielefeld.DE, dejagnu@gnu.org,
richard.guenther@gmail.com
Subject: Re: ping*2: [RFA:] testsuite infrastructure for options implied by dg-final methods
Date: Fri, 04 Nov 2011 17:54:00 -0000 [thread overview]
Message-ID: <201111041741.pA4HfKI9007137@ignucius.se.axis.com> (raw)
In-Reply-To: <CF1BCB78-2D35-4ECF-844B-CC841075CF48@comcast.net> (message from Mike Stump on Fri, 4 Nov 2011 17:53:05 +0100)
> From: Mike Stump <mikestump@comcast.net>
> Date: Fri, 4 Nov 2011 17:53:05 +0100
> On Nov 4, 2011, at 6:47 AM, Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote:
> > Ping again, CC:ing testsuite maintainers.
>
> With the number of qualified individuals commenting in the
> thread, I was going to stay out of it. If all the breakages
> and review point others had are resolved, Ok.
I know people responded to my patch message when reporting
problems after Honza's LTO_TORTURE_OPTIONS change but as I
mentioned, those breakages were unrelated to my patch, and
AFAICT mostly for load_lib ordering problems and for not setting
GCC_UNDER_TEST properly in Honza's original change for use in
other testsuites. I should have guessed and I'll remember to
scream loudly next time I'm implicated that way. :)
I looked and it seemed that Richi's problems was unresolved,
running
make check-gfortran RUNTESTFLAGS="dg.exp=logical_dot_product.f90"
supposedly in the obj/gcc subdir - use check-fortran from the
obj/ toplevel. But I can't repeat it neither with nor without my
patch. Richi?
> I kinda don't
> like the brittle upvars.
That's just the way it has to be done to inspect the necessary
dejagnu state and how other lib/*.exp infrastructure parts are
doing it, some for exactly the same "upvar" (lto and scanasm).
If this use breaks, they break too.
I thought about it, but found no other way. Maybe as a future
dejagnu improvements introducing stable hooks in dejagnu would
be one way to do it. (For dejagnu folks convenience, thread at
<http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01917.html>)
> If someone has a substantially less
> brittle method that does not use upvar and is reasonably
> concise and readable...
I'll wait a few days.
brgds, H-P
next prev parent reply other threads:[~2011-11-04 17:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 17:54 Update testsuite to run with slim LTO Jan Hubicka
2011-09-30 14:56 ` Diego Novillo
2011-10-20 19:34 ` Breakage with "Update testsuite to run with slim LTO" Hans-Peter Nilsson
2011-10-20 19:53 ` Andi Kleen
2011-10-21 0:39 ` Jan Hubicka
2011-10-21 5:22 ` [RFA:] fix breakage " Hans-Peter Nilsson
2011-10-21 9:58 ` Jan Hubicka
2011-10-21 12:23 ` Iain Sandoe
2011-10-21 12:35 ` Rainer Orth
2011-10-21 16:20 ` Jan Hubicka
2011-10-21 17:40 ` Hans-Peter Nilsson
2011-10-21 18:52 ` Jan Hubicka
2011-10-21 19:56 ` Hans-Peter Nilsson
2011-10-24 12:08 ` Richard Guenther
2011-10-28 14:59 ` ping: [RFA:] testsuite infrastructure for options implied by dg-final methods Hans-Peter Nilsson
2011-11-04 13:56 ` ping*2: " Hans-Peter Nilsson
2011-11-04 17:05 ` Mike Stump
2011-11-04 17:54 ` Hans-Peter Nilsson [this message]
2011-11-04 18:14 ` Mike Stump
2011-11-04 18:16 ` Hans-Peter Nilsson
2023-05-03 11:16 ` Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS' (was: Update testsuite to run with slim LTO) Thomas Schwinge
2023-05-03 11:46 ` Richard Biener
2023-05-09 7:32 ` Christophe Lyon
2023-05-09 9:00 ` Testsuite: Add missing 'torture-init'/'torture-finish' around 'LTO_TORTURE_OPTIONS' usage (was: Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS') Thomas Schwinge
2023-05-09 15:17 ` Christophe Lyon
2023-05-09 19:14 ` Christophe Lyon
2023-05-10 7:51 ` Testsuite: Add 'torture-init-done', and use it to conditionalize implicit 'torture-init' (was: Testsuite: Add missing 'torture-init'/'torture-finish' around 'LTO_TORTURE_OPTIONS' usage (was: Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS')) Thomas Schwinge
2023-05-10 13:42 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111041741.pA4HfKI9007137@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=dejagnu@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
--cc=mikestump@comcast.net \
--cc=richard.guenther@gmail.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).