From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22704 invoked by alias); 4 Nov 2011 17:41:58 -0000 Received: (qmail 22692 invoked by uid 22791); 4 Nov 2011 17:41:57 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Nov 2011 17:41:26 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id C092419EE3; Fri, 4 Nov 2011 18:41:22 +0100 (CET) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id y8GDNKaTP3Tm; Fri, 4 Nov 2011 18:41:21 +0100 (CET) Received: from seth.se.axis.com (seth.se.axis.com [10.0.2.172]) by anubis.se.axis.com (Postfix) with ESMTP id 6E39F19EAE; Fri, 4 Nov 2011 18:41:21 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by seth.se.axis.com (Postfix) with ESMTP id 6A9163E0E4; Fri, 4 Nov 2011 18:41:21 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id pA4HfLF6007141; Fri, 4 Nov 2011 18:41:21 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id pA4HfKI9007137; Fri, 4 Nov 2011 18:41:20 +0100 Date: Fri, 04 Nov 2011 17:54:00 -0000 Message-Id: <201111041741.pA4HfKI9007137@ignucius.se.axis.com> From: Hans-Peter Nilsson To: mikestump@comcast.net CC: hp@axis.com, gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE, dejagnu@gnu.org, richard.guenther@gmail.com In-reply-to: (message from Mike Stump on Fri, 4 Nov 2011 17:53:05 +0100) Subject: Re: ping*2: [RFA:] testsuite infrastructure for options implied by dg-final methods MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg00624.txt.bz2 > From: Mike Stump > Date: Fri, 4 Nov 2011 17:53:05 +0100 > On Nov 4, 2011, at 6:47 AM, Hans-Peter Nilsson wrote: > > Ping again, CC:ing testsuite maintainers. > > With the number of qualified individuals commenting in the > thread, I was going to stay out of it. If all the breakages > and review point others had are resolved, Ok. I know people responded to my patch message when reporting problems after Honza's LTO_TORTURE_OPTIONS change but as I mentioned, those breakages were unrelated to my patch, and AFAICT mostly for load_lib ordering problems and for not setting GCC_UNDER_TEST properly in Honza's original change for use in other testsuites. I should have guessed and I'll remember to scream loudly next time I'm implicated that way. :) I looked and it seemed that Richi's problems was unresolved, running make check-gfortran RUNTESTFLAGS="dg.exp=logical_dot_product.f90" supposedly in the obj/gcc subdir - use check-fortran from the obj/ toplevel. But I can't repeat it neither with nor without my patch. Richi? > I kinda don't > like the brittle upvars. That's just the way it has to be done to inspect the necessary dejagnu state and how other lib/*.exp infrastructure parts are doing it, some for exactly the same "upvar" (lto and scanasm). If this use breaks, they break too. I thought about it, but found no other way. Maybe as a future dejagnu improvements introducing stable hooks in dejagnu would be one way to do it. (For dejagnu folks convenience, thread at ) > If someone has a substantially less > brittle method that does not use upvar and is reasonably > concise and readable... I'll wait a few days. brgds, H-P