From: Kaz Kojima <kkojima@rr.iij4u.or.jp>
To: joern.rennecke@embecosm.com
Cc: gcc-patches@gcc.gnu.org
Subject: Re: RFT: Fix PR middle/end-40154
Date: Tue, 08 Nov 2011 14:57:00 -0000 [thread overview]
Message-ID: <20111108.231211.353111095.kkojima@rr.iij4u.or.jp> (raw)
In-Reply-To: <20111108081145.k697g6oymos8c4so-nzlynne@webmail.spamcop.net>
Joern Rennecke <joern.rennecke@embecosm.com> wrote:
> That's true, and it is by design.
> This use of set_unique_reg_note is a bit debatable - add_reg_note
> should do just fine there.
>
> OTOH keeping this as it is, and keeping set_unique_reg_note accepting USE
> in this case, seems more conservative for stage3.
A tiny change was needed
--- trunk/gcc/emit-rtl.c.orig 2011-11-08 22:46:20.000000000 +0900
+++ trunk/gcc/emit-rtl.c 2011-11-08 22:53:16.000000000 +0900
@@ -4974,7 +4974,7 @@ set_unique_reg_note (rtx insn, enum reg_
}
else /* Reload uses USEs with REG_EQUAL notes attached to keep track of
reload inhertiance opportunities. */
- gcc_assert (PATTERN (insn) == USE && reload_in_progress);
+ gcc_assert (GET_CODE (PATTERN (insn)) == USE && reload_in_progress);
note = find_reg_note (insn, kind, NULL_RTX);
switch (kind)
I'm regtesting the patch on SH, though currently many C++ tests fail
on SH with
undefined reference to `std::atomic_thread_fence(std::memory_order)'.
Regards,
kaz
next prev parent reply other threads:[~2011-11-08 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 0:32 joern.rennecke
2011-11-08 12:38 ` Kaz Kojima
2011-11-08 13:30 ` Joern Rennecke
2011-11-08 14:57 ` Kaz Kojima [this message]
2011-11-09 15:04 ` Kaz Kojima
2011-11-08 12:47 ` Eric Botcazou
2011-11-08 13:12 ` Joern Rennecke
2011-11-08 13:37 ` Eric Botcazou
2011-11-08 13:40 ` Joern Rennecke
2011-11-10 16:23 ` Eric Botcazou
2011-11-08 14:03 ` Joern Rennecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108.231211.353111095.kkojima@rr.iij4u.or.jp \
--to=kkojima@rr.iij4u.or.jp \
--cc=gcc-patches@gcc.gnu.org \
--cc=joern.rennecke@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).