From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9482 invoked by alias); 8 Nov 2011 14:12:35 -0000 Received: (qmail 9466 invoked by uid 22791); 8 Nov 2011 14:12:34 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mo11.iij4u.or.jp (HELO mo.iij4u.or.jp) (210.138.174.79) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Nov 2011 14:12:15 +0000 Received: by mo.iij4u.or.jp (mo11) id pA8ECB8H019244; Tue, 8 Nov 2011 23:12:11 +0900 Received: from localhost (238.152.138.210.bn.2iij.net [210.138.152.238]) by mbox.iij4u.or.jp (mbox10) id pA8ECACE019384; Tue, 8 Nov 2011 23:12:11 +0900 Date: Tue, 08 Nov 2011 14:57:00 -0000 Message-Id: <20111108.231211.353111095.kkojima@rr.iij4u.or.jp> To: joern.rennecke@embecosm.com Cc: gcc-patches@gcc.gnu.org Subject: Re: RFT: Fix PR middle/end-40154 From: Kaz Kojima In-Reply-To: <20111108081145.k697g6oymos8c4so-nzlynne@webmail.spamcop.net> References: <00264351905752@mail.embecosm.com> <20111108.211651.151281633.kkojima@rr.iij4u.or.jp> <20111108081145.k697g6oymos8c4so-nzlynne@webmail.spamcop.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg01191.txt.bz2 Joern Rennecke wrote: > That's true, and it is by design. > This use of set_unique_reg_note is a bit debatable - add_reg_note > should do just fine there. > > OTOH keeping this as it is, and keeping set_unique_reg_note accepting USE > in this case, seems more conservative for stage3. A tiny change was needed --- trunk/gcc/emit-rtl.c.orig 2011-11-08 22:46:20.000000000 +0900 +++ trunk/gcc/emit-rtl.c 2011-11-08 22:53:16.000000000 +0900 @@ -4974,7 +4974,7 @@ set_unique_reg_note (rtx insn, enum reg_ } else /* Reload uses USEs with REG_EQUAL notes attached to keep track of reload inhertiance opportunities. */ - gcc_assert (PATTERN (insn) == USE && reload_in_progress); + gcc_assert (GET_CODE (PATTERN (insn)) == USE && reload_in_progress); note = find_reg_note (insn, kind, NULL_RTX); switch (kind) I'm regtesting the patch on SH, though currently many C++ tests fail on SH with undefined reference to `std::atomic_thread_fence(std::memory_order)'. Regards, kaz