From: Joern Rennecke <joern.rennecke@embecosm.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: RFT: Fix PR middle/end-40154
Date: Tue, 08 Nov 2011 13:12:00 -0000 [thread overview]
Message-ID: <20111108074714.ayp71feie8g4wkok-nzlynne@webmail.spamcop.net> (raw)
In-Reply-To: <201111081325.22318.ebotcazou@adacore.com>
Quoting Eric Botcazou <ebotcazou@adacore.com>:
>> This fixes the problem on the Epiphany, but I haven't tested if it also
>> fixes it on the SH - AAUI you'd have to back out a workaround first to
>> properly test it.
>
> The fix belongs in the caller instead - it should make sure that what it is
> doing makes sense at all.
set_unique_reg note already makes a number of checks so that its
multitude of callers doesn't have to. E.g. it checks that there is
indeed only one set,
not only one set of a live register.
As you can see in the PR, there are different pieces in the compiler that
end up in the same bogosity as they add notes with the wrong mode of data.
Having the check & fix in one place makes this better maintainable.
next prev parent reply other threads:[~2011-11-08 12:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 0:32 joern.rennecke
2011-11-08 12:38 ` Kaz Kojima
2011-11-08 13:30 ` Joern Rennecke
2011-11-08 14:57 ` Kaz Kojima
2011-11-09 15:04 ` Kaz Kojima
2011-11-08 12:47 ` Eric Botcazou
2011-11-08 13:12 ` Joern Rennecke [this message]
2011-11-08 13:37 ` Eric Botcazou
2011-11-08 13:40 ` Joern Rennecke
2011-11-10 16:23 ` Eric Botcazou
2011-11-08 14:03 ` Joern Rennecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108074714.ayp71feie8g4wkok-nzlynne@webmail.spamcop.net \
--to=joern.rennecke@embecosm.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).