public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: amodra@gmail.com
Cc: gcc-patches@gcc.gnu.org, bernds@codesourcery.com
Subject: Revert "PowerPC shrink-wrap support 3 of 3"
Date: Thu, 10 Nov 2011 11:25:00 -0000	[thread overview]
Message-ID: <201111101038.pAAAcJIT006280@ignucius.se.axis.com> (raw)
In-Reply-To: <201111090855.pA98txkZ003552@ignucius.se.axis.com> (message from	Hans-Peter Nilsson on Wed, 9 Nov 2011 09:55:59 +0100)

> From: Hans-Peter Nilsson <hp@axis.com>
> Date: Wed, 9 Nov 2011 09:55:59 +0100

> > From: Alan Modra <amodra@gmail.com>
> > Date: Tue, 1 Nov 2011 16:33:40 +0100
> 
> > On Tue, Nov 01, 2011 at 12:57:22AM +1030, Alan Modra wrote:
> 
> >         * function.c (bb_active_p): Delete.
> >         (dup_block_and_redirect, active_insn_between): New functions.
> >         (convert_jumps_to_returns, emit_return_for_exit): New functions,
> >         split out from..
> >         (thread_prologue_and_epilogue_insns): ..here.  Delete
> >         shadowing variables.  Don't do prologue register clobber tests
> >         when shrink wrapping already failed.  Delete all last_bb_active
> >         code.  Instead compute tail block candidates for duplicating
> >         exit path.  Remove these from antic set.  Duplicate tails when
> >         reached from both blocks needing a prologue/epilogue and
> >         blocks not needing such.
> >         * ifcvt.c (dead_or_predicable): Test both flag_shrink_wrap and
> >         HAVE_simple_return.
> >         * bb-reorder.c (get_uncond_jump_length): Make global.
> >         * bb-reorder.h (get_uncond_jump_length): Declare.
> >         * cfgrtl.c (rtl_create_basic_block): Comment typo fix.
> >         (rtl_split_edge): Likewise.  Warning fix.
> >         (rtl_duplicate_bb): New function.
> >         (rtl_cfg_hooks): Enable can_duplicate_block_p and duplicate_block.
> 
> This (a revision in the range 181187:181189) broke build for
> cris-elf like so:
> See PR51051.

Given that this also broke arm-linux-gnueabi, a primary
platform, and Alan being absent until the 15th according to a
message on IRC, I move to revert r181188.

I think I need someone with appropriate write privileges to
agree with that, and to also give 48h for someone to fix the
problem.  Sorry for not forthcoming on the second point.

brgds, H-P
PS. where is the policy written down, besides the mailing list archives?

  reply	other threads:[~2011-11-10 10:39 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-17  7:59 PowerPC shrink-wrap support 0 of 3 Alan Modra
2011-09-17  8:22 ` PowerPC shrink-wrap support 1 " Alan Modra
2011-09-17  9:13 ` PowerPC shrink-wrap support 2 " Alan Modra
2011-09-17  9:26 ` PowerPC shrink-wrap support 3 " Alan Modra
2011-09-26 14:25   ` Alan Modra
2011-09-27  0:15     ` Alan Modra
2011-09-27  0:19       ` Bernd Schmidt
2011-09-27  0:49         ` Alan Modra
2011-09-27  1:08           ` Bernd Schmidt
2011-09-27  2:16             ` Alan Modra
2011-09-28 16:35               ` Alan Modra
2011-10-16 20:19                 ` David Edelsohn
2011-10-26 13:03                   ` Alan Modra
2011-10-26 13:42                     ` Bernd Schmidt
2011-10-26 14:40                       ` Alan Modra
2011-10-26 14:44                         ` Bernd Schmidt
2011-10-26 15:40                           ` Alan Modra
2011-10-28  0:41                         ` Alan Modra
2011-10-31 15:14                     ` Alan Modra
2011-11-01 15:34                       ` Alan Modra
2011-11-07 17:27                         ` Jakub Jelinek
2011-11-09  9:48                         ` Hans-Peter Nilsson
2011-11-10 11:25                           ` Hans-Peter Nilsson [this message]
2011-11-10 12:10                             ` Revert "PowerPC shrink-wrap support 3 of 3" Richard Guenther
2011-11-10 13:29                               ` Hans-Peter Nilsson
2011-11-10 13:44                                 ` Richard Guenther
2011-11-10 14:13                                   ` Bernd Schmidt
2011-11-10 15:23                                     ` Hans-Peter Nilsson
2011-11-10 18:06                                       ` Hans-Peter Nilsson
2011-11-11 22:09                                         ` Hans-Peter Nilsson
2011-11-14 14:59                                           ` Bernd Schmidt
2011-11-14 16:49                                             ` CFG review needed for fix of " Hans-Peter Nilsson
2011-11-14 17:06                                               ` Ramana Radhakrishnan
2011-11-14 17:15                                                 ` Rainer Orth
2011-11-14 18:21                                               ` Richard Henderson
2011-11-14 22:44                                                 ` Alan Modra
2011-11-15  2:50                                                   ` Hans-Peter Nilsson
2011-11-15  5:03                                                   ` Richard Henderson
2011-11-15  6:11                                                     ` Bernd Schmidt
2011-11-15  7:09                                                       ` David Miller
2011-11-15 18:54                                                   ` Richard Henderson
2011-11-15  0:45                                                 ` Hans-Peter Nilsson
2011-11-11  0:22                                     ` Revert " Michael Meissner
2015-04-08 11:11                             ` Gerald Pfeifer
2011-09-17 18:16 ` PowerPC shrink-wrap support 0 of 3 Bernd Schmidt
2011-09-19  5:39   ` Alan Modra
2011-09-19 13:36     ` Bernd Schmidt
     [not found]       ` <20110921152851.GE10321@bubble.grove.modra.org>
     [not found]         ` <20110922144017.GF10321@bubble.grove.modra.org>
2011-09-26 14:35           ` [PATCH] PowerPC shrink-wrap support benchmark gains Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111101038.pAAAcJIT006280@ignucius.se.axis.com \
    --to=hans-peter.nilsson@axis.com \
    --cc=amodra@gmail.com \
    --cc=bernds@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).