From: Benjamin Kosnik <bkoz@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>,
joseph@codesourcery.com, gcc-patches@gcc.gnu.org,
libstdc++@gcc.gnu.org, rth@redhat.com
Subject: Re: cxx-mem-model merge [6 of 9] - libstdc++-v3
Date: Fri, 11 Nov 2011 17:49:00 -0000 [thread overview]
Message-ID: <20111110214329.523635d8@shotwell> (raw)
In-Reply-To: <4EB92EDD.7080709@redhat.com>
> > I just realized I may be feeding you an inconsistent
> > configuration, see the atomicity stuff in
> > libstdc++-v3/config/cpu/cris. Is that just obsolete and unused
> > now or what do I need to add for that to work?
> >
>
> You don't need to do anything there. I think that atomicity stuff
> will soon be obsolete, but bkoz will have to answer that question.
> It looks to me like that was some gnu atomic extentions which predate
> atomic support in the standard. In theory, that would all be able to
> go away or be integrated into the gcc machine description with the
> modern patterns, if its not already there.
That is very obsolete and should be removed as it's now just
causing confusion. That was pre-builtin days, let's call this
atomics-try-1. So, all:
config/cpu/*/atomicity.h
./i486/atomicity.h
./i386/atomicity.h
./sparc/atomicity.h
./sh/atomicity.h
./m68k/atomicity.h
./cris/atomicity.h
./hppa/atomicity.h
./generic/atomicity_mutex/atomicity.h
./generic/atomicity_builtins/atomicity.h
ATOMICITY_SRCDIR
ATOMIC_WORD_SRCDIR
ATOMIC_FLAGS
Should go. I'll look in to peeling off this cruft sharpish.
> bkoz: As relates to the existing problem, how is the legacy support
> invoked in compatibility-atomic-c++0x.cc? That has the old style
> implementation of atomic_flag with a lock, which would allow this
> target to compile... which is another option perhaps. or is that
> purely for pervious releases somehow?
compatibility-atomic-c++0x.cc is the support for previous builtins
attempt, let's call this atomics-try-2. We need to keep these symbols
exported and doing the same thing done in previous releases. (Or else
abi-check will fail.)
If this system used to use a lock to work, then that is what it should
still do. The behavior shouldn't change.
-benjamin
next prev parent reply other threads:[~2011-11-11 17:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 23:52 Andrew MacLeod
2011-11-04 18:17 ` Jeff Law
2011-11-04 18:53 ` Andrew MacLeod
2011-11-07 0:54 ` Hans-Peter Nilsson
2011-11-07 4:48 ` Andrew MacLeod
2011-11-07 11:36 ` Hans-Peter Nilsson
2011-11-07 14:41 ` Andrew MacLeod
2011-11-07 14:56 ` Andrew MacLeod
2011-11-07 15:38 ` Hans-Peter Nilsson
2011-11-07 16:28 ` Joseph S. Myers
2011-11-07 17:24 ` Andrew MacLeod
2011-11-07 17:43 ` Hans-Peter Nilsson
2011-11-07 18:27 ` Andrew MacLeod
2011-11-08 6:45 ` Hans-Peter Nilsson
2011-11-08 13:43 ` Andrew MacLeod
2011-11-11 17:49 ` Benjamin Kosnik [this message]
2011-11-11 17:56 ` Andrew MacLeod
2011-11-11 21:07 ` Hans-Peter Nilsson
2011-11-11 23:34 ` Torvald Riegel
2011-11-11 20:27 ` Hans-Peter Nilsson
2011-11-07 16:32 ` Richard Henderson
2011-11-08 20:22 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110214329.523635d8@shotwell \
--to=bkoz@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
--cc=joseph@codesourcery.com \
--cc=libstdc++@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).