From: David Miller <davem@davemloft.net>
To: bernds@codesourcery.com
Cc: rth@redhat.com, hans-peter.nilsson@axis.com, hp@axis.com,
gcc-patches@gcc.gnu.org
Subject: Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"
Date: Tue, 15 Nov 2011 07:09:00 -0000 [thread overview]
Message-ID: <20111114.213351.458622373727839971.davem@davemloft.net> (raw)
In-Reply-To: <4EC1B84A.4070008@codesourcery.com>
From: Bernd Schmidt <bernds@codesourcery.com>
Date: Tue, 15 Nov 2011 01:54:34 +0100
> On 11/15/11 01:43, Richard Henderson wrote:
>> On 11/14/2011 11:56 AM, Alan Modra wrote:
>>> * function.c (thread_prologue_and_epilogue_insns): Guard
>>> emitting return with single_succ_p test.
>>
>> Hmm. This looks plausible too.
>>
>> Bernd's patch made sure that cfglayout didn't do something impossible.
>> Of course, it's possible that his patch should merely be an assert,
>> and the correct fix goes here.
>
> I haven't really looked at Alan's patch; I'm thinking there were
> probably two bugs - the one I found being latent before. Note that the
> problematic CFG exists way before thread_prologue_and_epilogue even
> runs, so an assert would still trigger.
I suspect that Alan's fix here will take care of the sparc ada bootstrap
regression reported, and regardless if it's correct it should be installed.
next prev parent reply other threads:[~2011-11-15 2:34 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-17 7:59 PowerPC shrink-wrap support 0 of 3 Alan Modra
2011-09-17 8:22 ` PowerPC shrink-wrap support 1 " Alan Modra
2011-09-17 9:13 ` PowerPC shrink-wrap support 2 " Alan Modra
2011-09-17 9:26 ` PowerPC shrink-wrap support 3 " Alan Modra
2011-09-26 14:25 ` Alan Modra
2011-09-27 0:15 ` Alan Modra
2011-09-27 0:19 ` Bernd Schmidt
2011-09-27 0:49 ` Alan Modra
2011-09-27 1:08 ` Bernd Schmidt
2011-09-27 2:16 ` Alan Modra
2011-09-28 16:35 ` Alan Modra
2011-10-16 20:19 ` David Edelsohn
2011-10-26 13:03 ` Alan Modra
2011-10-26 13:42 ` Bernd Schmidt
2011-10-26 14:40 ` Alan Modra
2011-10-26 14:44 ` Bernd Schmidt
2011-10-26 15:40 ` Alan Modra
2011-10-28 0:41 ` Alan Modra
2011-10-31 15:14 ` Alan Modra
2011-11-01 15:34 ` Alan Modra
2011-11-07 17:27 ` Jakub Jelinek
2011-11-09 9:48 ` Hans-Peter Nilsson
2011-11-10 11:25 ` Revert "PowerPC shrink-wrap support 3 of 3" Hans-Peter Nilsson
2011-11-10 12:10 ` Richard Guenther
2011-11-10 13:29 ` Hans-Peter Nilsson
2011-11-10 13:44 ` Richard Guenther
2011-11-10 14:13 ` Bernd Schmidt
2011-11-10 15:23 ` Hans-Peter Nilsson
2011-11-10 18:06 ` Hans-Peter Nilsson
2011-11-11 22:09 ` Hans-Peter Nilsson
2011-11-14 14:59 ` Bernd Schmidt
2011-11-14 16:49 ` CFG review needed for fix of " Hans-Peter Nilsson
2011-11-14 17:06 ` Ramana Radhakrishnan
2011-11-14 17:15 ` Rainer Orth
2011-11-14 18:21 ` Richard Henderson
2011-11-14 22:44 ` Alan Modra
2011-11-15 2:50 ` Hans-Peter Nilsson
2011-11-15 5:03 ` Richard Henderson
2011-11-15 6:11 ` Bernd Schmidt
2011-11-15 7:09 ` David Miller [this message]
2011-11-15 18:54 ` Richard Henderson
2011-11-15 0:45 ` Hans-Peter Nilsson
2011-11-11 0:22 ` Revert " Michael Meissner
2015-04-08 11:11 ` Gerald Pfeifer
2011-09-17 18:16 ` PowerPC shrink-wrap support 0 of 3 Bernd Schmidt
2011-09-19 5:39 ` Alan Modra
2011-09-19 13:36 ` Bernd Schmidt
[not found] ` <20110921152851.GE10321@bubble.grove.modra.org>
[not found] ` <20110922144017.GF10321@bubble.grove.modra.org>
2011-09-26 14:35 ` [PATCH] PowerPC shrink-wrap support benchmark gains Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114.213351.458622373727839971.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
--cc=hp@axis.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).