From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11583 invoked by alias); 15 Nov 2011 02:34:17 -0000 Received: (qmail 11425 invoked by uid 22791); 15 Nov 2011 02:34:16 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_CF X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (198.137.202.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Nov 2011 02:34:03 +0000 Received: from localhost (cpe-66-65-61-233.nyc.res.rr.com [66.65.61.233]) (authenticated bits=0) by shards.monkeyblade.net (8.14.4/8.14.4) with ESMTP id pAF2Xq4N026110 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Nov 2011 18:33:52 -0800 Date: Tue, 15 Nov 2011 07:09:00 -0000 Message-Id: <20111114.213351.458622373727839971.davem@davemloft.net> To: bernds@codesourcery.com Cc: rth@redhat.com, hans-peter.nilsson@axis.com, hp@axis.com, gcc-patches@gcc.gnu.org Subject: Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3" From: David Miller In-Reply-To: <4EC1B84A.4070008@codesourcery.com> References: <20111114215648.GI14325@bubble.grove.modra.org> <4EC1B5B7.2090107@redhat.com> <4EC1B84A.4070008@codesourcery.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg01706.txt.bz2 From: Bernd Schmidt Date: Tue, 15 Nov 2011 01:54:34 +0100 > On 11/15/11 01:43, Richard Henderson wrote: >> On 11/14/2011 11:56 AM, Alan Modra wrote: >>> * function.c (thread_prologue_and_epilogue_insns): Guard >>> emitting return with single_succ_p test. >> >> Hmm. This looks plausible too. >> >> Bernd's patch made sure that cfglayout didn't do something impossible. >> Of course, it's possible that his patch should merely be an assert, >> and the correct fix goes here. > > I haven't really looked at Alan's patch; I'm thinking there were > probably two bugs - the one I found being latent before. Note that the > problematic CFG exists way before thread_prologue_and_epilogue even > runs, so an assert would still trigger. I suspect that Alan's fix here will take care of the sparc ada bootstrap regression reported, and regardless if it's correct it should be installed.