From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25632 invoked by alias); 14 Nov 2011 14:10:28 -0000 Received: (qmail 25623 invoked by uid 22791); 14 Nov 2011 14:10:27 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from ra.se.axis.com (HELO ra.se.axis.com) (195.60.68.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Nov 2011 14:10:12 +0000 Received: from localhost (localhost [127.0.0.1]) by ra.se.axis.com (Postfix) with ESMTP id A37BD4B553; Mon, 14 Nov 2011 15:10:08 +0100 (CET) Received: from ra.se.axis.com ([127.0.0.1]) by localhost (ra.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NWCnNhU4MJTY; Mon, 14 Nov 2011 15:10:07 +0100 (CET) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by ra.se.axis.com (Postfix) with ESMTP id BD37B4B551; Mon, 14 Nov 2011 15:10:07 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id AD105340BD; Mon, 14 Nov 2011 15:10:07 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id pAEEA7F6014538; Mon, 14 Nov 2011 15:10:07 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id pAEEA7NZ014534; Mon, 14 Nov 2011 15:10:07 +0100 Date: Mon, 14 Nov 2011 16:49:00 -0000 Message-Id: <201111141410.pAEEA7NZ014534@ignucius.se.axis.com> From: Hans-Peter Nilsson To: bernds@codesourcery.com CC: hp@axis.com, gcc-patches@gcc.gnu.org In-reply-to: <4EC0E4BC.4060204@codesourcery.com> (message from Bernd Schmidt on Mon, 14 Nov 2011 10:51:56 +0100) Subject: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3" MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg01649.txt.bz2 > From: Bernd Schmidt > Date: Mon, 14 Nov 2011 10:51:56 +0100 > On 11/11/11 20:13, Hans-Peter Nilsson wrote: > > AFAICT, your patch has got sufficiently testing now (on three > > targets to boot) to be considered safe to check in. Or is > > something amiss? > > > > (If it's the unchecked code quality you mentioned, that can be > > just as well dealt with having the tree in a working state; > > having the tree broken for some targets accomplishes nothing.) > > I briefly looked at that, and while it does tend to move stuff around > compared to an unpatched compiler, the effects don't seem to be all that > bad. If we find a testcase where it's a real problem, we could do more > aggressive reordering after epilogue generation, when we no longer have > exit fallthroguh edges. So I'd like to ask for an OK here. Looks like all we need is a positive review of and a ChangeLog entry to unbreak three or more targets. Someone with approval rights: pretty please? brgds, H-P