From: Jakub Jelinek <jakub@redhat.com>
To: Razya Ladelsky <RAZYA@il.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Richard Guenther <richard.guenther@gmail.com>
Subject: Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence
Date: Mon, 21 Nov 2011 16:13:00 -0000 [thread overview]
Message-ID: <20111121150754.GJ27242@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <OF53481D2E.E48C0FB3-ONC225794F.004F7C31-C225794F.0051DEC3@il.ibm.com>
On Mon, Nov 21, 2011 at 04:54:09PM +0200, Razya Ladelsky wrote:
> Although compute_affine_dependence() can't do anything meaningful for the
> gather data refs,
> it may still be assigning values to the dependence relation structure, if
> you need to use them.
> Therefore I did not skip the call to compute_self_dependence(), which
> indeed calls
> compute_affine_depepndence().
>
>
> If you think it's redundant, we can remove it.
It is not just redundant, but harmful. compute_affine_dependence assumes
that base and offset are simple IVs, that is not true for gather deps.
So please do remove it.
Jakub
next prev parent reply other threads:[~2011-11-21 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 7:21 [patch] " Razya Ladelsky
2011-10-17 8:53 ` Richard Guenther
[not found] ` <OF746BCB18.CF82809F-ONC225792E.0051CE3F-C225792E.00564975@il.ibm.com>
[not found] ` <CAFiYyc2ykFPCW8A8vW=f5UbNa7zFRQObwL13D9ioXjCd_em9pQ@mail.gmail.com>
2011-10-21 9:26 ` Fwd: " Richard Guenther
2011-11-15 15:13 ` [PATCH, take 2] " Razya Ladelsky
2011-11-15 18:54 ` Richard Guenther
2011-11-21 13:32 ` Jakub Jelinek
2011-11-21 14:24 ` Razya Ladelsky
2011-11-21 14:54 ` Jakub Jelinek
2011-11-21 15:43 ` Razya Ladelsky
2011-11-21 16:13 ` Jakub Jelinek [this message]
2011-11-21 17:25 ` Razya Ladelsky
2011-11-21 18:26 ` Jakub Jelinek
2011-11-24 15:48 ` Razya Ladelsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121150754.GJ27242@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=RAZYA@il.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).