From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1744 invoked by alias); 21 Nov 2011 15:08:12 -0000 Received: (qmail 1735 invoked by uid 22791); 21 Nov 2011 15:08:11 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Nov 2011 15:07:56 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pALF7tHT011658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 21 Nov 2011 10:07:55 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pALF7tmp001568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 21 Nov 2011 10:07:55 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id pALF7sFm008843; Mon, 21 Nov 2011 16:07:54 +0100 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id pALF7sQV008841; Mon, 21 Nov 2011 16:07:54 +0100 Date: Mon, 21 Nov 2011 16:13:00 -0000 From: Jakub Jelinek To: Razya Ladelsky Cc: GCC Patches , Richard Guenther Subject: Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence Message-ID: <20111121150754.GJ27242@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <20111121125707.GG27242@tyan-ft48-01.lab.bos.redhat.com> <20111121135915.GH27242@tyan-ft48-01.lab.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg02110.txt.bz2 On Mon, Nov 21, 2011 at 04:54:09PM +0200, Razya Ladelsky wrote: > Although compute_affine_dependence() can't do anything meaningful for the > gather data refs, > it may still be assigning values to the dependence relation structure, if > you need to use them. > Therefore I did not skip the call to compute_self_dependence(), which > indeed calls > compute_affine_depepndence(). > > > If you think it's redundant, we can remove it. It is not just redundant, but harmful. compute_affine_dependence assumes that base and offset are simple IVs, that is not true for gather deps. So please do remove it. Jakub