public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@adacore.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Support Solaris 11/SPARC in MD_FALLBACK_FRAME_STATE_FOR (PR ada/41929)
Date: Tue, 17 Jan 2012 11:23:00 -0000	[thread overview]
Message-ID: <201201171217.33428.ebotcazou@adacore.com> (raw)
In-Reply-To: <yddwr8r7t6a.fsf@manam.CeBiTec.Uni-Bielefeld.DE>

> Unfortunately, this version completely breaks Solaris 11.  Given that
> your primary (only?) justification for this patch seems to be a 7-year
> old Beta version of Solaris 10 (s10_72) nobody in his right mind should
> be running right now, I suggest simply reverting this patch.

I think that we shoudn't have changed the pattern matching code in the first 
place, as it had gradually evolved over almost an entire decade.  It was quite 
robust as a consequence and the new code is clearly inferior in this respect.

Usually adapting it to a new version of the OS only takes a handful of minutes.
Would you mind having a quick look?  I don't have access to Solaris 11 myself.

-- 
Eric Botcazou

  reply	other threads:[~2012-01-17 11:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 12:33 Rainer Orth
2011-11-28 22:16 ` Eric Botcazou
2012-01-09  9:51   ` Eric Botcazou
2012-01-16 12:01     ` Rainer Orth
2012-01-17 11:23       ` Eric Botcazou [this message]
2012-01-17 12:41         ` Rainer Orth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201171217.33428.ebotcazou@adacore.com \
    --to=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ro@cebitec.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).