From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13429 invoked by alias); 15 Mar 2012 12:40:14 -0000 Received: (qmail 13410 invoked by uid 22791); 15 Mar 2012 12:40:12 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Mar 2012 12:39:58 +0000 Received: by wibhq7 with SMTP id hq7so7098832wib.8 for ; Thu, 15 Mar 2012 05:39:57 -0700 (PDT) Received: by 10.180.91.10 with SMTP id ca10mr25969382wib.17.1331815197144; Thu, 15 Mar 2012 05:39:57 -0700 (PDT) Received: from s42.loc (85-127-250-184.dynamic.xdsl-line.inode.at. [85.127.250.184]) by mx.google.com with ESMTPS id l5sm4775808wia.11.2012.03.15.05.39.55 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Mar 2012 05:39:56 -0700 (PDT) Received: from cow by s42.loc with local (Exim 4.77) (envelope-from ) id 1S89yE-0007Hb-VY; Thu, 15 Mar 2012 13:39:54 +0100 Date: Thu, 15 Mar 2012 12:40:00 -0000 From: Bernhard Reutner-Fischer To: Mike Stump Cc: Mikael Morin , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE Subject: Re: [PATCH] gfortran testsuite: implicitly cleanup-modules Message-ID: <20120315123954.GA27018@mx.loc> References: <20070327170903.GA11737@aon.at> <1330636193-25099-1-git-send-email-rep.dot.nop@gmail.com> <4F594879.7080203@sfr.fr> <20120313163858.GB29875@mx.loc> <3D0569AE-048B-40F9-B916-523B32670B6B@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D0569AE-048B-40F9-B916-523B32670B6B@comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01049.txt.bz2 On Tue, Mar 13, 2012 at 01:30:29PM -0700, Mike Stump wrote: >On Mar 13, 2012, at 9:38 AM, Bernhard Reutner-Fischer wrote: >> Could some of the testsuite maintainers please eyeball? > >I've eyed it, the only thing that stood out was: > >-foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.F]] { >- if ![runtest_file_p $runtests $testcase] then { >- continue >- } >- fortran-torture $testcase >-} >- >-foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.f90]] { >- if ![runtest_file_p $runtests $testcase] then { >- continue >- } >- fortran-torture $testcase >-} > >which, I hope does what you want. It replaces a manually unrolled loop with a loop over the testcase-extensions and works as expected. Or did you mean something else? > >Assuming you like those parts, Ok. committed as r185430. > >Since it touches non-fortran, please watch for and respond to any problems it might cause. Of course, as always. PS: I saw that the cleanup-tree-dump is also a bit redundant. When looking at e.g. gcc/testsuite/gcc.dg/pr52578.c one would think that scan-tree-dump-times might be able to automagically collect which dumpfiles to cleanup as last step in dg-final. One could go one step further and even implicitly add the corresponding dg-options according to the expected scan-tree-dump files although this might not be worth it iff there are passes that may produce dump-files different to their pass name (did not look if this is possible). One would have to strip the pass-number off the dump-file for passes that are run more than once, too. Just a thought.. Thanks and cheers,