public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [SH] PR 52642 - libstdc++ failures
@ 2012-03-20 20:40 Oleg Endo
  2012-03-21  3:15 ` Kaz Kojima
  0 siblings, 1 reply; 2+ messages in thread
From: Oleg Endo @ 2012-03-20 20:40 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Hi,

Attached is Kaz's patch from the PR.

Tested against rev 185555 with 
make -k check RUNTESTFLAGS="--target_board=sh-sim
\{-m2/-ml,-m2/-mb,-m2a-single/-mb,
-m4-single/-ml,-m4-single/-mb,
-m4a-single/-ml,-m4a-single/-mb}"

It fixes a few "sometimes failing" libstdc++ failures.
No new failures otherwise.

OK to apply?

Maybe this one should be backported to 4.7.x, too?

Cheers,
Oleg


ChangeLog:

	PR/target 52642
	* config/sh/sh.c (sh_expand_prologue): Emit blockage at the end
	of prologue for unwinder and profiler.


[-- Attachment #2: pr52642.patch --]
[-- Type: text/x-patch, Size: 727 bytes --]

Index: gcc/config/sh/sh.c
===================================================================
--- gcc/config/sh/sh.c	(revision 185554)
+++ gcc/config/sh/sh.c	(working copy)
@@ -7239,6 +7239,13 @@
       emit_insn (gen_shcompact_incoming_args ());
     }
 
+  /* If we are profiling, make sure no instructions are scheduled before
+     the call to mcount.  Similarly if some call instructions are swapped
+     before frame related insns, it'll confuse the unwinder because
+     currently SH has no unwind info for function epilogues.  */
+  if (crtl->profile || flag_exceptions || flag_unwind_tables)
+    emit_insn (gen_blockage ());
+
   if (flag_stack_usage_info)
     current_function_static_stack_size = stack_usage;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [SH] PR 52642 - libstdc++ failures
  2012-03-20 20:40 [SH] PR 52642 - libstdc++ failures Oleg Endo
@ 2012-03-21  3:15 ` Kaz Kojima
  0 siblings, 0 replies; 2+ messages in thread
From: Kaz Kojima @ 2012-03-21  3:15 UTC (permalink / raw)
  To: oleg.endo; +Cc: gcc-patches

Oleg Endo <oleg.endo@t-online.de> wrote:
> It fixes a few "sometimes failing" libstdc++ failures.
> No new failures otherwise.
> 
> OK to apply?

OK.

> Maybe this one should be backported to 4.7.x, too?

Sure.

Regards,
	kaz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-21  3:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-20 20:40 [SH] PR 52642 - libstdc++ failures Oleg Endo
2012-03-21  3:15 ` Kaz Kojima

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).