From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6743 invoked by alias); 21 Mar 2012 21:53:49 -0000 Received: (qmail 6733 invoked by uid 22791); 21 Mar 2012 21:53:45 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Mar 2012 21:53:32 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 976D329004B; Wed, 21 Mar 2012 22:53:33 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oUswVQfgy4yQ; Wed, 21 Mar 2012 22:53:33 +0100 (CET) Received: from [192.168.1.2] (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 61AF3290015; Wed, 21 Mar 2012 22:53:33 +0100 (CET) From: Eric Botcazou To: Aurelien Buhrig Subject: Re: [PATCH] Bug fix in store_bit_field_1 for big endian targets (issue 51893) Date: Wed, 21 Mar 2012 21:53:00 -0000 User-Agent: KMail/1.9.9 Cc: gcc-patches@gcc.gnu.org References: <4F69979E.4070502@gmail.com> In-Reply-To: <4F69979E.4070502@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201203212253.07335.ebotcazou@adacore.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01461.txt.bz2 > This patch (for 4.6) fixes a wrong subword index computation in > store_bit_field_1 for big endian targets when value is at least 4 times > bigger than a word (DI REG value with HI words). > > It fixes a regression on gcc.c-torture/execute/bitfld-3.c for my current > backend port. > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51893 > > OK to commit? It is OK for mainline on principle but there is no ChangeLog entry and the patch doesn't follow the GNU Coding Style: TABs instead of spaces, spaces before parentheses, etc. See the equivalent code in extract_bit_field_1. Moreover you need to properly test it on a mainstream big-endian platform. See http://gcc.gnu.org/contribute.html for a more complete reference. -- Eric Botcazou