Re: [PATCH] gfortran testsuite: implicitly cleanup-modules

[Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>]

On Mon, Mar 19, 2012 at 06:36:12PM +0100, Rainer Orth wrote:

>Unfortunately, this patch creates a bogus warning in the libgomp
>testsuite, which also shows up in mail-report.log:
>
>WARNING: Line 30 includes unreadable file \`/vol/gcc/src/hg/trunk/local/libgomp/testsuite/libgomp.fortran/omp_lib.h'
>
>fortran-modules.exp (list-module-names-1) assumes that included files
>are relative to the source, but omp_lib.h is a generated file and lives
>in $objdir, and is found at compile time via -I switches.

fortran-modules does not (currently) use include-dir search path logic
to find include files.
>
>Besides, the message is less than helpful since it gives no indication
>as to which files includes the missing one.

RUNTESTFLAGS='-v -v' (for example) shows the testcase that it currently
works on, as you know.
>
>Please fix.

I have removed the unwarranted warning after successful (1) toplevel
regtesting and committed it as r185688.

The second part of the "implicit cleanup-modules" would be to remove
the now superfluous manual cleanup-modules calls.

Something like this, ran in the sourcedir removes those:
(cd gcc/testsuite && grep -rl "cleanup-modules" * | \
 egrep -v "(\.exp|ChangeLog|\.svn|gfortran.dg/(class_4(a|b|c|5a).f03|binding_label_tests_1(0|1|1_main|3|3_main).f03|test_common_binding_labels_(2|2_main|3|3_main).f03|whole_file_(28|29|30|31).f90))" | \
 while read f;do \
   sed -i -e ':crap' -e '/cleanup-modules/d' -e '/^\n*$/{$d;N;bcrap' -e '}' $f; \
 done)

1) Completely unrelated bug in the testsuite showed up as 2 regressions
in the above testing. I have filed that as gcc.gnu.org/PR52665