From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26198 invoked by alias); 22 Mar 2012 12:30:35 -0000 Received: (qmail 26179 invoked by uid 22791); 22 Mar 2012 12:30:32 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-we0-f175.google.com (HELO mail-we0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Mar 2012 12:30:16 +0000 Received: by wera1 with SMTP id a1so1974756wer.20 for ; Thu, 22 Mar 2012 05:30:14 -0700 (PDT) Received: by 10.180.81.166 with SMTP id b6mr4697561wiy.0.1332419414448; Thu, 22 Mar 2012 05:30:14 -0700 (PDT) Received: from s42.loc (85-127-19-88.dynamic.xdsl-line.inode.at. [85.127.19.88]) by mx.google.com with ESMTPS id df3sm4933977wib.1.2012.03.22.05.30.11 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 22 Mar 2012 05:30:12 -0700 (PDT) Received: from cow by s42.loc with local (Exim 4.77) (envelope-from ) id 1SAh9e-0007Va-KR; Thu, 22 Mar 2012 13:30:10 +0100 Date: Thu, 22 Mar 2012 12:30:00 -0000 From: Bernhard Reutner-Fischer To: Rainer Orth Cc: Jakub Jelinek , Richard Guenther , Mike Stump , Mikael Morin , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] gfortran testsuite: implicitly cleanup-modules Message-ID: <20120322123010.GA26674@mx.loc> References: <1330636193-25099-1-git-send-email-rep.dot.nop@gmail.com> <4F594879.7080203@sfr.fr> <20120313163858.GB29875@mx.loc> <3D0569AE-048B-40F9-B916-523B32670B6B@comcast.net> <20120315123954.GA27018@mx.loc> <20120315165632.GC24587@mx.loc> <20120315193547.GC16117@tyan-ft48-01.lab.bos.redhat.com> <20120316100445.GA30354@mx.loc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01498.txt.bz2 On Mon, Mar 19, 2012 at 06:36:12PM +0100, Rainer Orth wrote: >Unfortunately, this patch creates a bogus warning in the libgomp >testsuite, which also shows up in mail-report.log: > >WARNING: Line 30 includes unreadable file \`/vol/gcc/src/hg/trunk/local/libgomp/testsuite/libgomp.fortran/omp_lib.h' > >fortran-modules.exp (list-module-names-1) assumes that included files >are relative to the source, but omp_lib.h is a generated file and lives >in $objdir, and is found at compile time via -I switches. fortran-modules does not (currently) use include-dir search path logic to find include files. > >Besides, the message is less than helpful since it gives no indication >as to which files includes the missing one. RUNTESTFLAGS='-v -v' (for example) shows the testcase that it currently works on, as you know. > >Please fix. I have removed the unwarranted warning after successful (1) toplevel regtesting and committed it as r185688. The second part of the "implicit cleanup-modules" would be to remove the now superfluous manual cleanup-modules calls. Something like this, ran in the sourcedir removes those: (cd gcc/testsuite && grep -rl "cleanup-modules" * | \ egrep -v "(\.exp|ChangeLog|\.svn|gfortran.dg/(class_4(a|b|c|5a).f03|binding_label_tests_1(0|1|1_main|3|3_main).f03|test_common_binding_labels_(2|2_main|3|3_main).f03|whole_file_(28|29|30|31).f90))" | \ while read f;do \ sed -i -e ':crap' -e '/cleanup-modules/d' -e '/^\n*$/{$d;N;bcrap' -e '}' $f; \ done) 1) Completely unrelated bug in the testsuite showed up as 2 regressions in the above testing. I have filed that as gcc.gnu.org/PR52665