From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27766 invoked by alias); 23 Mar 2012 03:39:52 -0000 Received: (qmail 27757 invoked by uid 22791); 23 Mar 2012 03:39:51 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gy0-f175.google.com (HELO mail-gy0-f175.google.com) (209.85.160.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Mar 2012 03:39:38 +0000 Received: by ghbz2 with SMTP id z2so2592603ghb.20 for ; Thu, 22 Mar 2012 20:39:37 -0700 (PDT) Received: by 10.68.135.40 with SMTP id pp8mr25578720pbb.13.1332473977187; Thu, 22 Mar 2012 20:39:37 -0700 (PDT) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id k2sm4905336pba.28.2012.03.22.20.39.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 22 Mar 2012 20:39:36 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 3331EEA2B83; Fri, 23 Mar 2012 14:09:30 +1030 (CST) Date: Fri, 23 Mar 2012 03:39:00 -0000 From: Alan Modra To: Eric Botcazou Cc: Aurelien Buhrig , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Bug fix in store_bit_field_1 for big endian targets (issue 51893) Message-ID: <20120323033930.GF5097@bubble.grove.modra.org> Mail-Followup-To: Eric Botcazou , Aurelien Buhrig , gcc-patches@gcc.gnu.org References: <4F69979E.4070502@gmail.com> <201203212253.07335.ebotcazou@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201203212253.07335.ebotcazou@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01547.txt.bz2 On Wed, Mar 21, 2012 at 10:53:07PM +0100, Eric Botcazou wrote: > > This patch (for 4.6) fixes a wrong subword index computation in > > store_bit_field_1 for big endian targets when value is at least 4 times > > bigger than a word (DI REG value with HI words). > > > > It fixes a regression on gcc.c-torture/execute/bitfld-3.c for my current > > backend port. > > > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51893 > > > > OK to commit? > > It is OK for mainline on principle but there is no ChangeLog entry and the > patch doesn't follow the GNU Coding Style: TABs instead of spaces, spaces > before parentheses, etc. See the equivalent code in extract_bit_field_1. > Moreover you need to properly test it on a mainstream big-endian platform. Passes bootstrap and regression test powerpc64-linux. -- Alan Modra Australia Development Lab, IBM