public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@adacore.com>
To: Richard Guenther <rguenther@suse.de>
Cc: Richard Guenther <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PRs 52080, 52097 and 48124, rewrite bitfield expansion, enable the C++ memory model wrt bitfields everywhere
Date: Tue, 27 Mar 2012 08:39:00 -0000	[thread overview]
Message-ID: <201203271038.32329.ebotcazou@adacore.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1203270948230.5416@jbgna.fhfr.qr>

> I see.  Though the code does not affect layout but only access "layout"
> for bitfields.  I'm fine with fixing the issues we run into elsewhere,
> just the langhook is a possibility I had in mind from the start, in
> case frontends differ in their memory model for bitfields.

Understood.  According to our internal testing, the issue we're discussing was 
the last problem introduced by the bitfield change, and I think that using the 
C/C++ model for C/C++-compatible bit fields is fine for GNAT.

May I apply the patch I posted?  It boostrapped/regtested fine on x86-64/Linux.

-- 
Eric Botcazou

  reply	other threads:[~2012-03-27  8:38 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 13:26 Richard Guenther
2012-03-09  9:02 ` Eric Botcazou
2012-03-12  9:38   ` Richard Guenther
2012-03-12 10:21     ` Eric Botcazou
2012-03-13 14:19       ` Richard Guenther
2012-03-15 14:43         ` Eric Botcazou
2012-03-15 14:58           ` Richard Guenther
2012-03-15 15:30             ` Richard Guenther
2012-03-15 16:19               ` Eric Botcazou
2012-03-15 17:03                 ` Eric Botcazou
2012-03-16  9:42                   ` Richard Guenther
2012-03-19 10:45                     ` Eric Botcazou
2012-03-19 13:14                       ` Richard Guenther
2012-03-20  9:30                         ` Richard Guenther
2012-03-22 10:26                           ` Eric Botcazou
2012-03-22 10:38                             ` Richard Guenther
2012-03-22 11:13                               ` Eric Botcazou
2012-03-22 11:22                                 ` Richard Guenther
2012-03-22 11:48                                   ` Eric Botcazou
2012-03-22 12:04                                     ` Richard Guenther
2012-03-22 12:18                                       ` Eric Botcazou
2012-03-22 12:39                                         ` Richard Guenther
2012-03-23  9:13                                           ` Richard Guenther
2012-03-26  7:18                                             ` Eric Botcazou
2012-03-26  7:37                                               ` Richard Guenther
2012-03-26  7:43                                                 ` Eric Botcazou
2012-03-26  8:01                                                   ` Richard Guenther
2012-03-26  8:18                                                     ` Eric Botcazou
2012-03-26  8:34                                                       ` Richard Guenther
2012-03-26 17:54                                                         ` Eric Botcazou
2012-03-27  6:51                                                           ` Richard Guenther
2012-03-27  7:08                                                             ` Eric Botcazou
2012-03-27  7:50                                                               ` Richard Guenther
2012-03-27  8:39                                                                 ` Eric Botcazou [this message]
2012-03-27  8:47                                                                   ` Richard Guenther
2012-03-30 20:58                                                                     ` Eric Botcazou
2012-04-02 14:23                                                                       ` Richard Guenther
2012-04-03  8:26                                                                         ` Eric Botcazou
2012-04-03  8:34                                                                           ` Richard Guenther
2012-04-03 11:09                                                                             ` Eric Botcazou
2012-04-03 11:44                                                                               ` Richard Guenther
2012-03-26  8:10                                                   ` Eric Botcazou
2012-03-26  8:52                                                     ` Richard Guenther
2012-03-26 18:04                                                       ` Eric Botcazou
2012-03-27  6:51                                                         ` Richard Guenther
2012-03-26  7:18                                           ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203271038.32329.ebotcazou@adacore.com \
    --to=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).