From: Peter Bergner <bergner@vnet.ibm.com>
To: Paolo Carlini <paolo.carlini@oracle.com>
Cc: Janis Johnson <janis_johnson@mentor.com>,
gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs
Date: Fri, 03 Aug 2012 05:01:00 -0000 [thread overview]
Message-ID: <20120803000059.52337dce6ecbb94a42534bc5@vnet.ibm.com> (raw)
In-Reply-To: <501A4A2A.6090808@oracle.com>
On Thu, 02 Aug 2012 11:36:42 Paolo Carlini wrote:
> > Also, is this ok for the 4.6 and 4.7 release branches?
> I don't think this is a regression, thus I would say 4.7 only, to be safe.
Ok.
> we don't have a separate ChangeLog in libstdc++-v3/testsuite/. Thus a
> single ChangeLog entry for everything.
Fixed.
> > Index: libstdc++-v3/testsuite/decimal/pr54036-1.cc
> > ===================================================================
> > --- libstdc++-v3/testsuite/decimal/pr54036-1.cc (revision 0)
> > +++ libstdc++-v3/testsuite/decimal/pr54036-1.cc (revision 0)
> > @@ -0,0 +1,56 @@
> Copyright blurb missing. Also, you need:
>
> // { dg-require-effective-target dfp }
Fixed.
> In the library testsuite we include:
>
> #include <testsuite_hooks.h>
>
> and then we use VERIFY not __builtin_abort. Also, for decimal, we
> normally use:
>
> using namespace std::decimal.
Fixed.
Ok, once more with feeling! :) How about the updated patched below?
...and thank you for the gentle review. This is my first libstdc++
patch and I guess I was used to the normal gcc/testsuite/ tests
that don't include copyright headers and the like. I'll try to
be more careful in the future.
Peter
libstdc++-v3/
PR libstdc++/54036
* include/decimal/decimal.h (_DEFINE_DECIMAL_UNARY_OP): Use _Op as
a unary operator.
* testsuite/decimal/pr54036-1.cc: New test.
* testsuite/decimal/pr54036-2.cc: Likewise.
* testsuite/decimal/pr54036-3.cc: Likewise.
Index: libstdc++-v3/include/decimal/decimal.h
===================================================================
--- libstdc++-v3/include/decimal/decimal.h (revision 189599)
+++ libstdc++-v3/include/decimal/decimal.h (working copy)
@@ -288,7 +288,7 @@
inline _Tp operator _Op(_Tp __rhs) \
{ \
_Tp __tmp; \
- __tmp.__setval(0 _Op __rhs.__getval()); \
+ __tmp.__setval(_Op __rhs.__getval()); \
return __tmp; \
}
Index: libstdc++-v3/testsuite/decimal/pr54036-1.cc
===================================================================
--- libstdc++-v3/testsuite/decimal/pr54036-1.cc (revision 0)
+++ libstdc++-v3/testsuite/decimal/pr54036-1.cc (revision 0)
@@ -0,0 +1,70 @@
+// Copyright (C) 2012 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-require-effective-target dfp }
+
+#include <decimal/decimal>
+#include <testsuite_hooks.h>
+
+using namespace std::decimal;
+
+decimal32
+__attribute__ ((noinline))
+my_nan32 (void)
+{
+ decimal32 z = 0;
+ decimal32 v = z/z;
+ return v;
+}
+
+decimal32
+__attribute__ ((noinline))
+my_inf32 (void)
+{
+ decimal32 o = 1;
+ decimal32 z = 0;
+ decimal32 v = o/z;
+ return v;
+}
+
+int
+main (void)
+{
+ decimal32 v;
+
+ v = my_nan32 ();
+
+ VERIFY (__builtin_isnand32 (v.__getval ()));
+ VERIFY (!__builtin_signbitd32 (v.__getval ()))
+
+ v = -v;
+
+ VERIFY (__builtin_isnand32 (v.__getval ()));
+ VERIFY (__builtin_signbitd32 (v.__getval ()))
+
+ v = my_inf32 ();
+
+ VERIFY (__builtin_isinfd32 (v.__getval ()));
+ VERIFY (!__builtin_signbitd32 (v.__getval ()))
+
+ v = -v;
+
+ VERIFY (__builtin_isinfd32 (v.__getval ()));
+ VERIFY (__builtin_signbitd32 (v.__getval ()))
+
+ return 0;
+}
Index: libstdc++-v3/testsuite/decimal/pr54036-2.cc
===================================================================
--- libstdc++-v3/testsuite/decimal/pr54036-2.cc (revision 0)
+++ libstdc++-v3/testsuite/decimal/pr54036-2.cc (revision 0)
@@ -0,0 +1,70 @@
+// Copyright (C) 2012 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-require-effective-target dfp }
+
+#include <decimal/decimal>
+#include <testsuite_hooks.h>
+
+using namespace std::decimal;
+
+decimal64
+__attribute__ ((noinline))
+my_nan64 (void)
+{
+ decimal64 z = 0;
+ decimal64 v = z/z;
+ return v;
+}
+
+decimal64
+__attribute__ ((noinline))
+my_inf64 (void)
+{
+ decimal64 o = 1;
+ decimal64 z = 0;
+ decimal64 v = o/z;
+ return v;
+}
+
+int
+main (void)
+{
+ decimal64 v;
+
+ v = my_nan64 ();
+
+ VERIFY (__builtin_isnand64 (v.__getval ()));
+ VERIFY (!__builtin_signbitd64 (v.__getval ()))
+
+ v = -v;
+
+ VERIFY (__builtin_isnand64 (v.__getval ()));
+ VERIFY (__builtin_signbitd64 (v.__getval ()))
+
+ v = my_inf64 ();
+
+ VERIFY (__builtin_isinfd64 (v.__getval ()));
+ VERIFY (!__builtin_signbitd64 (v.__getval ()))
+
+ v = -v;
+
+ VERIFY (__builtin_isinfd64 (v.__getval ()));
+ VERIFY (__builtin_signbitd64 (v.__getval ()))
+
+ return 0;
+}
Index: libstdc++-v3/testsuite/decimal/pr54036-3.cc
===================================================================
--- libstdc++-v3/testsuite/decimal/pr54036-3.cc (revision 0)
+++ libstdc++-v3/testsuite/decimal/pr54036-3.cc (revision 0)
@@ -0,0 +1,70 @@
+// Copyright (C) 2012 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-require-effective-target dfp }
+
+#include <decimal/decimal>
+#include <testsuite_hooks.h>
+
+using namespace std::decimal;
+
+decimal128
+__attribute__ ((noinline))
+my_nan128 (void)
+{
+ decimal128 z = 0;
+ decimal128 v = z/z;
+ return v;
+}
+
+decimal128
+__attribute__ ((noinline))
+my_inf128 (void)
+{
+ decimal128 o = 1;
+ decimal128 z = 0;
+ decimal128 v = o/z;
+ return v;
+}
+
+int
+main (void)
+{
+ decimal128 v;
+
+ v = my_nan128 ();
+
+ VERIFY (__builtin_isnand128 (v.__getval ()));
+ VERIFY (!__builtin_signbitd128 (v.__getval ()))
+
+ v = -v;
+
+ VERIFY (__builtin_isnand128 (v.__getval ()));
+ VERIFY (__builtin_signbitd128 (v.__getval ()))
+
+ v = my_inf128 ();
+
+ VERIFY (__builtin_isinfd128 (v.__getval ()));
+ VERIFY (!__builtin_signbitd128 (v.__getval ()))
+
+ v = -v;
+
+ VERIFY (__builtin_isinfd128 (v.__getval ()));
+ VERIFY (__builtin_signbitd128 (v.__getval ()))
+
+ return 0;
+}
next prev parent reply other threads:[~2012-08-03 5:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 23:17 Peter Bergner
2012-08-01 14:00 ` Jason Merrill
2012-08-01 14:29 ` Paolo Carlini
2012-08-01 15:24 ` Janis Johnson
2012-08-01 23:54 ` Peter Bergner
2012-08-02 9:37 ` Paolo Carlini
2012-08-03 5:01 ` Peter Bergner [this message]
2012-08-03 9:29 ` Paolo Carlini
2012-08-13 22:15 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803000059.52337dce6ecbb94a42534bc5@vnet.ibm.com \
--to=bergner@vnet.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janis_johnson@mentor.com \
--cc=libstdc++@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).