From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25487 invoked by alias); 11 Aug 2012 16:39:49 -0000 Received: (qmail 25477 invoked by uid 22791); 11 Aug 2012 16:39:47 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 11 Aug 2012 16:39:35 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 968D9888013; Sat, 11 Aug 2012 18:39:33 +0200 (CEST) Date: Sat, 11 Aug 2012 16:39:00 -0000 From: Jan Hubicka To: Jan Hubicka , GCC Patches Subject: Re: [PATCH 2/3] Incorporate aggregate jump functions into inlining analysis Message-ID: <20120811163933.GC14041@kam.mff.cuni.cz> References: <20120810031723.GF12788@kam.mff.cuni.cz> <20120810031231.GE12788@kam.mff.cuni.cz> <20120810143943.GB11133@virgil.arch.suse.de> <20120811105854.GC11133@virgil.arch.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120811105854.GC11133@virgil.arch.suse.de> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg00684.txt.bz2 > This is the patch I have committed after resolving a conflict (and > another round of bootstrapping and testing). The ChangeLog is still > the same. > > The previous version of the patch (but with tree code already > converted to an enum), the aggregate jump functions together with > enlarged inlining predicates increased Mozilla Firefox LTO WPA memory > consumption by 1.2% (6775287 kb -> 6855035 kb as measured by > maxmem2.sh). On Monday I will make another measurement with jump > functions completely switched off. Thanks! I did bit of static analysis on Mozilla, we increase number of predicated instructions by about 30% that is quite good. We seem to be weaker on actually using the predicates however, about 1% of inline decisions lead to using those predicates. I guess there is room for improvements in jump functions construction/propagation, right? :) Looking at the dumps we get some quit interesting matches like memset call when the destination argument is known to be zero already etc. Honza