* [PATCH] Allow dg-skip-if to use compiler flags specified through set_board_info cflags
@ 2012-08-11 17:41 Senthil Kumar Selvaraj
2012-08-19 17:47 ` [PING][PATCH,dejagnu] " Senthil Kumar Selvaraj
2012-08-21 22:09 ` [PATCH] " Mike Stump
0 siblings, 2 replies; 5+ messages in thread
From: Senthil Kumar Selvaraj @ 2012-08-11 17:41 UTC (permalink / raw)
To: gcc-patches
This patch allows cflags set in board config files using
"set_board_info cflags" to be used in the selectors of
dg-skip-if and other dejagnu commands that use the check-flags
proc.
The code merely adds cflags to compiler_flags in the check-flags proc,
exactly the same way as multilib_flags is added.
Regards
Senthil
* lib/target-supports-dg.exp (check-flags): Add cflags from board
config to compiler_flags
diff --git a/gcc/testsuite/lib/target-supports-dg.exp b/gcc/testsuite/lib/target-supports-dg.exp
index 2f6c4c2..bdf7476 100644
--- a/gcc/testsuite/lib/target-supports-dg.exp
+++ b/gcc/testsuite/lib/target-supports-dg.exp
@@ -304,6 +304,9 @@ proc check-flags { args } {
# If running a subset of the test suite, $TEST_ALWAYS_FLAGS may not exist.
catch {append compiler_flags " $TEST_ALWAYS_FLAGS "}
set dest [target_info name]
+ if [board_info $dest exists cflags] {
+ append compiler_flags "[board_info $dest cflags] "
+ }
if [board_info $dest exists multilib_flags] {
append compiler_flags "[board_info $dest multilib_flags] "
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING][PATCH,dejagnu] Allow dg-skip-if to use compiler flags specified through set_board_info cflags
2012-08-11 17:41 [PATCH] Allow dg-skip-if to use compiler flags specified through set_board_info cflags Senthil Kumar Selvaraj
@ 2012-08-19 17:47 ` Senthil Kumar Selvaraj
2012-08-21 22:09 ` [PATCH] " Mike Stump
1 sibling, 0 replies; 5+ messages in thread
From: Senthil Kumar Selvaraj @ 2012-08-19 17:47 UTC (permalink / raw)
To: gcc-patches; +Cc: janisjo
Hello
On Sat, Aug 11, 2012 at 11:09:03PM +0530, Senthil Kumar Selvaraj wrote:
> This patch allows cflags set in board config files using
> "set_board_info cflags" to be used in the selectors of
> dg-skip-if and other dejagnu commands that use the check-flags
> proc.
>
> The code merely adds cflags to compiler_flags in the check-flags proc,
> exactly the same way as multilib_flags is added.
>
> Regards
> Senthil
>
> * lib/target-supports-dg.exp (check-flags): Add cflags from board
> config to compiler_flags
>
>
> diff --git a/gcc/testsuite/lib/target-supports-dg.exp b/gcc/testsuite/lib/target-supports-dg.exp
> index 2f6c4c2..bdf7476 100644
> --- a/gcc/testsuite/lib/target-supports-dg.exp
> +++ b/gcc/testsuite/lib/target-supports-dg.exp
> @@ -304,6 +304,9 @@ proc check-flags { args } {
> # If running a subset of the test suite, $TEST_ALWAYS_FLAGS may not exist.
> catch {append compiler_flags " $TEST_ALWAYS_FLAGS "}
> set dest [target_info name]
> + if [board_info $dest exists cflags] {
> + append compiler_flags "[board_info $dest cflags] "
> + }
> if [board_info $dest exists multilib_flags] {
> append compiler_flags "[board_info $dest multilib_flags] "
> }
Does the patch look ok?
Regards
Senthil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Allow dg-skip-if to use compiler flags specified through set_board_info cflags
2012-08-11 17:41 [PATCH] Allow dg-skip-if to use compiler flags specified through set_board_info cflags Senthil Kumar Selvaraj
2012-08-19 17:47 ` [PING][PATCH,dejagnu] " Senthil Kumar Selvaraj
@ 2012-08-21 22:09 ` Mike Stump
2012-08-22 7:05 ` Senthil Kumar Selvaraj
2012-09-18 7:00 ` [Ping] " Senthil Kumar Selvaraj
1 sibling, 2 replies; 5+ messages in thread
From: Mike Stump @ 2012-08-21 22:09 UTC (permalink / raw)
To: Senthil Kumar Selvaraj; +Cc: gcc-patches
On Aug 11, 2012, at 10:39 AM, Senthil Kumar Selvaraj wrote:
> This patch allows cflags set in board config files using
> "set_board_info cflags" to be used in the selectors of
> dg-skip-if and other dejagnu commands that use the check-flags
> proc.
Ok.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Allow dg-skip-if to use compiler flags specified through set_board_info cflags
2012-08-21 22:09 ` [PATCH] " Mike Stump
@ 2012-08-22 7:05 ` Senthil Kumar Selvaraj
2012-09-18 7:00 ` [Ping] " Senthil Kumar Selvaraj
1 sibling, 0 replies; 5+ messages in thread
From: Senthil Kumar Selvaraj @ 2012-08-22 7:05 UTC (permalink / raw)
To: Mike Stump; +Cc: gcc-patches
On Tue, Aug 21, 2012 at 03:08:43PM -0700, Mike Stump wrote:
> On Aug 11, 2012, at 10:39 AM, Senthil Kumar Selvaraj wrote:
> > This patch allows cflags set in board config files using
> > "set_board_info cflags" to be used in the selectors of
> > dg-skip-if and other dejagnu commands that use the check-flags
> > proc.
>
> Ok.
I forgot to mention that I don't have commit access - would you mind comitting
the patch to trunk for me?
Regards
Senthil
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Ping] Allow dg-skip-if to use compiler flags specified through set_board_info cflags
2012-08-21 22:09 ` [PATCH] " Mike Stump
2012-08-22 7:05 ` Senthil Kumar Selvaraj
@ 2012-09-18 7:00 ` Senthil Kumar Selvaraj
1 sibling, 0 replies; 5+ messages in thread
From: Senthil Kumar Selvaraj @ 2012-09-18 7:00 UTC (permalink / raw)
To: gcc-patches; +Cc: gcc-patches
Hello,
Could one of the maintainers please check in the patch below?
It was already approved at
http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00689.html
Regards
Senthil
On Tue, Aug 21, 2012 at 03:08:43PM -0700, Mike Stump wrote:
> On Aug 11, 2012, at 10:39 AM, Senthil Kumar Selvaraj wrote:
> > This patch allows cflags set in board config files using
> > "set_board_info cflags" to be used in the selectors of
> > dg-skip-if and other dejagnu commands that use the check-flags
> > proc.
>
> Ok.
* lib/target-supports-dg.exp (check-flags): Add cflags from board
config to compiler_flags
diff --git a/gcc/testsuite/lib/target-supports-dg.exp b/gcc/testsuite/lib/target-supports-dg.exp
index 2f6c4c2..bdf7476 100644
--- a/gcc/testsuite/lib/target-supports-dg.exp
+++ b/gcc/testsuite/lib/target-supports-dg.exp
@@ -304,6 +304,9 @@ proc check-flags { args } {
# If running a subset of the test suite, $TEST_ALWAYS_FLAGS may not exist.
catch {append compiler_flags " $TEST_ALWAYS_FLAGS "}
set dest [target_info name]
+ if [board_info $dest exists cflags] {
+ append compiler_flags "[board_info $dest cflags] "
+ }
if [board_info $dest exists multilib_flags] {
append compiler_flags "[board_info $dest multilib_flags] "
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-18 7:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-11 17:41 [PATCH] Allow dg-skip-if to use compiler flags specified through set_board_info cflags Senthil Kumar Selvaraj
2012-08-19 17:47 ` [PING][PATCH,dejagnu] " Senthil Kumar Selvaraj
2012-08-21 22:09 ` [PATCH] " Mike Stump
2012-08-22 7:05 ` Senthil Kumar Selvaraj
2012-09-18 7:00 ` [Ping] " Senthil Kumar Selvaraj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).