From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: terry.guo@arm.com (Terry Guo)
Cc: Richard.Earnshaw@arm.com (Richard Earnshaw), gcc-patches@gcc.gnu.org
Subject: Re: [Patch ARM] Update the test case to differ movs and lsrs for ARM mode and non-ARM mode
Date: Fri, 14 Sep 2012 10:14:00 -0000 [thread overview]
Message-ID: <201209141014.q8EAEGte000810@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <000401cd8057$8d1b0240$a75106c0$@guo@arm.com> from "Terry Guo" at Aug 22, 2012 07:16:14 PM
Terry Guo wrote:
> -/* { dg-final { scan-assembler "movs\tr\[0-9\]" } } */
> +/* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target arm_thumb2_ok } }
> } */
> +/* { dg-final { scan-assembler "movs\tr\[0-9\]" { target { ! arm_thumb2_ok
> } } } } */
This causes the arm.exp testcase to fail with a tcl error for me:
ERROR: tcl error sourcing /home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/arm.exp.
ERROR: unmatched open brace in list
while executing
"foreach op $tmp {
verbose "Processing option: $op" 3
set status [catch "$op" errmsg]
if { $status != 0 } {
if { 0 && [info exists errorInfo] }..."
(procedure "saved-dg-test" line 75)
invoked from within
"saved-dg-test /home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/combine-movs.c {} { -ansi -pedantic-errors}"
("eval" body line 1)
invoked from within
"eval saved-dg-test $args "
(procedure "dg-test" line 10)
invoked from within
"dg-test $testcase $flags ${default-extra-flags}"
(procedure "dg-runtest" line 10)
invoked from within
"dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cCS\]]] \
"" $DEFAULT_CFLAGS"
(file "/home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/arm.exp" line 37)
invoked from within
"source /home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/arm.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source /home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/arm.exp"
invoked from within
"catch "uplevel #0 source $test_file_name""
which seems to be caused by a missing space between two closing braces.
Fixed by the following patch.
Committed to mainline as obvious.
Bye,
Ulrich
ChangeLog:
* gcc.target/arm/combine-movs.c: Add missing space.
Index: gcc/testsuite/gcc.target/arm/combine-movs.c
===================================================================
*** gcc/testsuite/gcc.target/arm/combine-movs.c (revision 191254)
--- gcc/testsuite/gcc.target/arm/combine-movs.c (working copy)
*************** void foo (unsigned long r[], unsigned in
*** 9,13 ****
r[i] = 0;
}
! /* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target arm_thumb2_ok } }} */
/* { dg-final { scan-assembler "movs\tr\[0-9\]" { target { ! arm_thumb2_ok} } } } */
--- 9,13 ----
r[i] = 0;
}
! /* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target arm_thumb2_ok } } } */
/* { dg-final { scan-assembler "movs\tr\[0-9\]" { target { ! arm_thumb2_ok} } } } */
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2012-09-14 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 1:18 Terry Guo
2012-08-22 10:06 ` Richard Earnshaw
2012-08-22 11:15 ` Terry Guo
2012-08-22 14:16 ` Richard Earnshaw
2012-09-04 6:02 ` Terry Guo
2012-09-14 10:14 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209141014.q8EAEGte000810@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=terry.guo@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).