From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8830 invoked by alias); 14 Sep 2012 10:14:51 -0000 Received: (qmail 8821 invoked by uid 22791); 14 Sep 2012 10:14:50 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp14.uk.ibm.com (HELO e06smtp14.uk.ibm.com) (195.75.94.110) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Sep 2012 10:14:35 +0000 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Sep 2012 11:14:33 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 14 Sep 2012 11:14:20 +0100 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8EAEDFS46465172 for ; Fri, 14 Sep 2012 10:14:13 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8EAEIYA000968 for ; Fri, 14 Sep 2012 04:14:19 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q8EAEGte000810; Fri, 14 Sep 2012 04:14:16 -0600 Message-Id: <201209141014.q8EAEGte000810@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 14 Sep 2012 12:14:16 +0200 Subject: Re: [Patch ARM] Update the test case to differ movs and lsrs for ARM mode and non-ARM mode To: terry.guo@arm.com (Terry Guo) Date: Fri, 14 Sep 2012 10:14:00 -0000 From: "Ulrich Weigand" Cc: Richard.Earnshaw@arm.com (Richard Earnshaw), gcc-patches@gcc.gnu.org In-Reply-To: <000401cd8057$8d1b0240$a75106c0$@guo@arm.com> from "Terry Guo" at Aug 22, 2012 07:16:14 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 12091410-1948-0000-0000-000002F4317E Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-09/txt/msg00989.txt.bz2 Terry Guo wrote: > -/* { dg-final { scan-assembler "movs\tr\[0-9\]" } } */ > +/* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target arm_thumb2_ok } } > } */ > +/* { dg-final { scan-assembler "movs\tr\[0-9\]" { target { ! arm_thumb2_ok > } } } } */ This causes the arm.exp testcase to fail with a tcl error for me: ERROR: tcl error sourcing /home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/arm.exp. ERROR: unmatched open brace in list while executing "foreach op $tmp { verbose "Processing option: $op" 3 set status [catch "$op" errmsg] if { $status != 0 } { if { 0 && [info exists errorInfo] }..." (procedure "saved-dg-test" line 75) invoked from within "saved-dg-test /home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/combine-movs.c {} { -ansi -pedantic-errors}" ("eval" body line 1) invoked from within "eval saved-dg-test $args " (procedure "dg-test" line 10) invoked from within "dg-test $testcase $flags ${default-extra-flags}" (procedure "dg-runtest" line 10) invoked from within "dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cCS\]]] \ "" $DEFAULT_CFLAGS" (file "/home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/arm.exp" line 37) invoked from within "source /home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/arm.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source /home/uweigand/fsf/gcc-head/gcc/testsuite/gcc.target/arm/arm.exp" invoked from within "catch "uplevel #0 source $test_file_name"" which seems to be caused by a missing space between two closing braces. Fixed by the following patch. Committed to mainline as obvious. Bye, Ulrich ChangeLog: * gcc.target/arm/combine-movs.c: Add missing space. Index: gcc/testsuite/gcc.target/arm/combine-movs.c =================================================================== *** gcc/testsuite/gcc.target/arm/combine-movs.c (revision 191254) --- gcc/testsuite/gcc.target/arm/combine-movs.c (working copy) *************** void foo (unsigned long r[], unsigned in *** 9,13 **** r[i] = 0; } ! /* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target arm_thumb2_ok } }} */ /* { dg-final { scan-assembler "movs\tr\[0-9\]" { target { ! arm_thumb2_ok} } } } */ --- 9,13 ---- r[i] = 0; } ! /* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target arm_thumb2_ok } } } */ /* { dg-final { scan-assembler "movs\tr\[0-9\]" { target { ! arm_thumb2_ok} } } } */ -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com