From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27244 invoked by alias); 9 Oct 2012 22:58:46 -0000 Received: (qmail 27236 invoked by uid 22791); 9 Oct 2012 22:58:45 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,TW_FN X-Spam-Check-By: sourceware.org Received: from e8.ny.us.ibm.com (HELO e8.ny.us.ibm.com) (32.97.182.138) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Oct 2012 22:58:39 +0000 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Oct 2012 18:58:38 -0400 Received: from d01relay06.pok.ibm.com (9.56.227.116) by e8.ny.us.ibm.com (192.168.1.108) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 9 Oct 2012 18:58:35 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q99MwYZp32571432 for ; Tue, 9 Oct 2012 18:58:34 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q99MwXxt022432 for ; Tue, 9 Oct 2012 19:58:33 -0300 Received: from ibm-tiger.the-meissners.org ([9.33.48.180]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q99MwXmk022391; Tue, 9 Oct 2012 19:58:33 -0300 Received: by ibm-tiger.the-meissners.org (Postfix, from userid 500) id 2911C424B2; Tue, 9 Oct 2012 18:58:30 -0400 (EDT) Date: Tue, 09 Oct 2012 23:01:00 -0000 From: Michael Meissner To: Michael Meissner , David Edelsohn , gcc-patches@gcc.gnu.org, bergner@vnet.ibm.com, segher@kernel.crashing.org, iain@codesourcery.com, andreast-list@fgznet.ch Subject: Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2c Message-ID: <20121009225830.GA22469@ibm-tiger.the-meissners.org> Mail-Followup-To: Michael Meissner , David Edelsohn , gcc-patches@gcc.gnu.org, bergner@vnet.ibm.com, segher@kernel.crashing.org, iain@codesourcery.com, andreast-list@fgznet.ch References: <20120912224303.GA19348@ibm-tiger.the-meissners.org> <20120917195131.GA22648@ibm-tiger.the-meissners.org> <20120920195755.GA18581@ibm-tiger.the-meissners.org> <20120927224228.GA24889@ibm-tiger.the-meissners.org> <20121005194921.GA20004@ibm-tiger.the-meissners.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: <20121005194921.GA20004@ibm-tiger.the-meissners.org> User-Agent: Mutt/1.5.20 (2009-12-10) x-cbid: 12100922-9360-0000-0000-00000B8B41D5 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-10/txt/msg00921.txt.bz2 --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 966 Ok, David preferred the 2 series of patches which replace all of the flags in target_flags to rs6000_isa_flags to the 3 series of patches, which started over, and added a new flag word, but did not change the existing options. In an effort to simplify the main patch, I'm going to push out some of the patches that are standalone. This patch fixes the 3 signed/unsigned warnings that were caused by comparing an integer type with an enumeration. I did bootstap and make check with no regressions. Is it ok to install (it is probably ok under the obvious rule)? 2012-10-09 Michael Meissner * config/rs6000/rs6000.c (altivec_expand_dst_builtin): Fix signed vs. unsigned warnings by using enum type for function code. (paired_expand_builtin): Likewise. (spe_expand_builtin): Likewise. -- Michael Meissner, IBM 5 Technology Place Drive, M/S 2757, Westford, MA 01886-3141, USA meissner@linux.vnet.ibm.com fax +1 (978) 399-6899 --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="gcc-power7.patch359b" Content-length: 1276 Index: gcc/config/rs6000/rs6000.c =================================================================== --- gcc/config/rs6000/rs6000.c (revision 192265) +++ gcc/config/rs6000/rs6000.c (working copy) @@ -10442,7 +10442,7 @@ altivec_expand_dst_builtin (tree exp, rt bool *expandedp) { tree fndecl = TREE_OPERAND (CALL_EXPR_FN (exp), 0); - unsigned int fcode = DECL_FUNCTION_CODE (fndecl); + enum rs6000_builtins fcode = (enum rs6000_builtins) DECL_FUNCTION_CODE (fndecl); tree arg0, arg1, arg2; enum machine_mode mode0, mode1; rtx pat, op0, op1, op2; @@ -10844,7 +10844,7 @@ static rtx paired_expand_builtin (tree exp, rtx target, bool * expandedp) { tree fndecl = TREE_OPERAND (CALL_EXPR_FN (exp), 0); - unsigned int fcode = DECL_FUNCTION_CODE (fndecl); + enum rs6000_builtins fcode = (enum rs6000_builtins) DECL_FUNCTION_CODE (fndecl); const struct builtin_description *d; size_t i; @@ -10909,7 +10909,7 @@ spe_expand_builtin (tree exp, rtx target { tree fndecl = TREE_OPERAND (CALL_EXPR_FN (exp), 0); tree arg1, arg0; - unsigned int fcode = DECL_FUNCTION_CODE (fndecl); + enum rs6000_builtins fcode = (enum rs6000_builtins) DECL_FUNCTION_CODE (fndecl); enum insn_code icode; enum machine_mode tmode, mode0; rtx pat, op0; --9jxsPFA5p3P2qPhR--