From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11585 invoked by alias); 6 Nov 2012 18:27:04 -0000 Received: (qmail 11566 invoked by uid 22791); 6 Nov 2012 18:27:03 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (149.20.54.216) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Nov 2012 18:26:57 +0000 Received: from localhost (cpe-74-66-230-70.nyc.res.rr.com [74.66.230.70]) by shards.monkeyblade.net (Postfix) with ESMTPSA id B2C04584AF3; Tue, 6 Nov 2012 10:26:58 -0800 (PST) Date: Tue, 06 Nov 2012 18:27:00 -0000 Message-Id: <20121106.132653.1452112337479456596.davem@davemloft.net> To: hubicka@ucw.cz Cc: gcc-patches@gcc.gnu.org Subject: Re: New badness metric for inliner From: David Miller In-Reply-To: <20121106182146.GA13455@kam.mff.cuni.cz> References: <20121105135742.GA25731@kam.mff.cuni.cz> <20121105.142716.1037729744785787761.davem@davemloft.net> <20121106182146.GA13455@kam.mff.cuni.cz> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg00553.txt.bz2 From: Jan Hubicka Date: Tue, 6 Nov 2012 19:21:46 +0100 > The problem here is really that MAX_TIME * MAX_FREQ do not fit into 32bit integer. Fixed thus. > > * ipa-inline.c (compute_uninlined_call_time): Return gcov_type. > (compute_inlined_call_time): Watch overflows. > (relative_time_benefit): Compute in gcov_type. Thanks Jan, I'll test this right now.