From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-331246-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22753 invoked by alias); 6 Nov 2012 19:28:28 -0000
Received: (qmail 22745 invoked by uid 22791); 6 Nov 2012 19:28:27 -0000
X-SWARE-Spam-Status: No, hits=-3.3 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED
X-Spam-Check-By: sourceware.org
Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (149.20.54.216)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Nov 2012 19:28:21 +0000
Received: from localhost (cpe-74-66-230-70.nyc.res.rr.com [74.66.230.70])	by shards.monkeyblade.net (Postfix) with ESMTPSA id EC84C584C9E;	Tue,  6 Nov 2012 11:28:22 -0800 (PST)
Date: Tue, 06 Nov 2012 19:28:00 -0000
Message-Id: <20121106.142819.622271454405914107.davem@davemloft.net>
To: hubicka@ucw.cz
Cc: gcc-patches@gcc.gnu.org
Subject: Re: New badness metric for inliner
From: David Miller <davem@davemloft.net>
In-Reply-To: <20121106.141632.1584896609382278585.davem@davemloft.net>
References: <20121106.132653.1452112337479456596.davem@davemloft.net>	<20121106.135401.722269878532983745.davem@davemloft.net>	<20121106.141632.1584896609382278585.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-11/txt/msg00568.txt.bz2

From: David Miller <davem@davemloft.net>
Date: Tue, 06 Nov 2012 14:16:32 -0500 (EST)

> (gdb) p inline_summary (edge->caller)->time
> $1205 = -1044761

This negative value is computed by inline_update_overall_summary().

I added some debugging to dump the entry->time values processed when
info->time goes negative:

davem@patience:~/src/GIT/GCC/build-sparc32-linux/prev-gcc$ ./cc1plus -quiet -g -O2 -o x.s graphite-interchange.i
e[19]: time[0]
e[19]: time[3996]
e[19]: time[4000]
e[19]: time[1960]
e[19]: time[7840]
e[19]: time[980]
e[19]: time[4900]
e[19]: time[382]
e[19]: time[382]
e[19]: time[2292]
e[19]: time[10073452]
e[19]: time[6644]
e[19]: time[10865]
e[19]: time[726004281]
e[19]: time[10865]
e[19]: time[726004281]
e[19]: time[10865]
e[19]: time[726004281]
e[19]: time[3916]

My initial impression is that we'll need to use gcov_t all over the
place, which is unfortunate because that's going to make the inliner
more expensive on 32-bit builds.

Or perhaps we can get away with only using gcov_t for info->time, I'll
give that a try.