public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>,
	Uros Bizjak <ubizjak@gmail.com>,
	       Vladimir Yakovlev <vbyakovl23@gmail.com>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Vzeroupper placement/47440
Date: Tue, 06 Nov 2012 22:18:00 -0000	[thread overview]
Message-ID: <20121106221813.GZ1881@tucnak.redhat.com> (raw)
In-Reply-To: <CAMe9rOq9FRPOxgRAtT91m4_gpBOPqQgYZGznYJiSQkRrU41c6w@mail.gmail.com>

On Tue, Nov 06, 2012 at 02:11:50PM -0800, H.J. Lu wrote:
> On Tue, Nov 6, 2012 at 2:30 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > Hello,
> >> OK for mainline SVN, please commit.
> > Checked into GCC trunk: http://gcc.gnu.org/ml/gcc-cvs/2012-11/msg00176.html
> >
> > Thanks, K
> 
> This caused:
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55224

Not only that, it also broke --enable-checking=yes,rtl bootstrap.
SET_DEST isn't valid on CALL, but XEXP (call, 0) is a MEM anyway and
the code looks for reg, so I think looking for CALL was just a mistake.

This fixes the bootstrap, ok for trunk?

2012-11-06  Jakub Jelinek  <jakub@redhat.com>

	* config/i386/i386.c (ix86_avx_u128_mode_after): Don't
	look for reg in CALL operand.

--- gcc/config/i386/i386.c.jj	2012-11-06 18:10:22.000000000 +0100
+++ gcc/config/i386/i386.c	2012-11-06 20:15:09.068912242 +0100
@@ -15084,9 +15084,9 @@ ix86_avx_u128_mode_after (int mode, rtx
   /* Check for CALL instruction.  */
   if (CALL_P (insn))
     {
-      if (GET_CODE (pat) == SET || GET_CODE (pat) == CALL)
+      if (GET_CODE (pat) == SET)
 	reg = SET_DEST (pat);
-      else if (GET_CODE (pat) ==  PARALLEL)
+      else if (GET_CODE (pat) == PARALLEL)
 	for (i = XVECLEN (pat, 0) - 1; i >= 0; i--)
 	  {
 	    rtx x = XVECEXP (pat, 0, i);


	Jakub

  reply	other threads:[~2012-11-06 22:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05 19:52 Uros Bizjak
2012-11-06 10:30 ` Kirill Yukhin
2012-11-06 22:11   ` H.J. Lu
2012-11-06 22:18     ` Jakub Jelinek [this message]
2012-11-07  7:03       ` Uros Bizjak
2012-11-07  7:08         ` Uros Bizjak
2012-11-07  8:05           ` Jakub Jelinek
2012-11-07  9:42             ` Uros Bizjak
2012-11-07 12:19             ` Uros Bizjak
2012-11-07 15:09       ` Vladimir Yakovlev
2012-11-08  5:49         ` Vladimir Yakovlev
     [not found] <CAK1BsWrsVu4TRW50RW0X7G4RSguSAjhqFPe-tkeXKaurr=sX1A@mail.gmail.com>
     [not found] ` <CAFULd4b0y6GGZsn1s4-RXc1mAvZGrhGd4YQBhfLgeMWmv2eXPA@mail.gmail.com>
     [not found]   ` <CAK1BsWoL5hsfZprf-a8zxG+Bhe9SwGFwqxHxOw9UX+bbsFD5oQ@mail.gmail.com>
     [not found]     ` <CAFULd4bJXT-nnAk6HCn2C=+jhfiUD-fAe3LK8AYd9jgqQQHvKQ@mail.gmail.com>
     [not found]       ` <CAFULd4bdxuKbYYS7TcyRfjNukLvJ0d5pOD7zJGAyKEQLPq7z2Q@mail.gmail.com>
     [not found]         ` <CAK1BsWpL69eRHTD8dzVOm9xtOqtjcr6z3B2tvb_VikWPzKT0Dw@mail.gmail.com>
     [not found]           ` <CAFULd4YaVLCYF=Huw_kDozTBTcZnGUAy7xOcV+VEweOWZ5Cigg@mail.gmail.com>
     [not found]             ` <CAFULd4YyRVY4BzD+csZAqCCmB7v3YEwAaOpNW9QsMXEbCkFw+Q@mail.gmail.com>
2012-11-09 12:18               ` [off-list] " Vladimir Yakovlev
2012-11-09 12:29                 ` Uros Bizjak
2012-11-09 12:36                   ` Jakub Jelinek
2012-11-09 12:48                     ` Uros Bizjak
2012-11-09 13:28                       ` Uros Bizjak
2012-11-16  7:50                         ` Uros Bizjak
  -- strict thread matches above, loose matches on Subject: below --
2012-11-04 13:29 Uros Bizjak
2012-11-04 17:59 ` Uros Bizjak
     [not found] ` <CAK1BsWpoD4AVB_4+J6snJgs4BF1Jbiw-RrifvZiiAm21qRURew@mail.gmail.com>
     [not found]   ` <CAFULd4Y5zDhMH3h34Lt0O5xNG+xibDJih7q2_ctef7nqSNJcOQ@mail.gmail.com>
2012-11-04 20:28     ` Vladimir Yakovlev
2012-11-04  4:31 Vladimir Yakovlev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121106221813.GZ1881@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=kirill.yukhin@gmail.com \
    --cc=ubizjak@gmail.com \
    --cc=vbyakovl23@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).