From: Jakub Jelinek <jakub@redhat.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] Remove inline keyword from rs6000 legitimate_indirect_address_p (PR target/54308)
Date: Thu, 08 Nov 2012 17:42:00 -0000 [thread overview]
Message-ID: <20121108174215.GC1859@tucnak.redhat.com> (raw)
Hi!
We have in rs6000-protos.h
extern bool legitimate_indirect_address_p (rtx, int);
and in rs6000.c
inline bool
legitimate_indirect_address_p (rtx x, int strict) { ... }
and in predicates.md call this function. That works fine in C
(both -fgnu89-inline mode and C99), the function is inlined within rs6000.c
but an out of line copy is still emitted and predicates.md can thus
reference it. But in C++, if compiled with optimizations, without
-fkeep-inline-functions and the compiler inlines all calls to that function,
it doesn't have to emit anything. Thus, either we have the option to
move the definition of legitimate_indirect_address_p into a header (but
rs6000-protos.h doesn't look like a correct spot to define inline
functions), or we need to drop inline keyword and force that way
an out of line copy. Ok for trunk?
2012-11-08 Jakub Jelinek <jakub@redhat.com>
PR target/54308
* config/rs6000/rs6000.c (legitimate_indirect_address_p): Remove
inline keyword.
--- gcc/config/rs6000/rs6000.c.jj 2012-10-31 09:20:44.000000000 +0100
+++ gcc/config/rs6000/rs6000.c 2012-11-08 18:33:34.950408593 +0100
@@ -5465,7 +5465,7 @@ avoiding_indexed_address_p (enum machine
return (TARGET_AVOID_XFORM && VECTOR_MEM_NONE_P (mode));
}
-inline bool
+bool
legitimate_indirect_address_p (rtx x, int strict)
{
return GET_CODE (x) == REG && INT_REG_OK_FOR_BASE_P (x, strict);
Jakub
next reply other threads:[~2012-11-08 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 17:42 Jakub Jelinek [this message]
2012-11-08 19:32 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108174215.GC1859@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).