From: Jakub Jelinek <jakub@redhat.com>
To: Vladimir Makarov <vmakarov@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: patch to fix PR55512
Date: Thu, 29 Nov 2012 08:35:00 -0000 [thread overview]
Message-ID: <20121129083519.GV2315@tucnak.redhat.com> (raw)
In-Reply-To: <50B64D33.3040505@redhat.com>
On Wed, Nov 28, 2012 at 12:43:15PM -0500, Vladimir Makarov wrote:
> The following patch fixes
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55512
>
> The patch was successfully tested and bootstrapped on x86/x86-64.
>
> Committed as rev. 193901.
>
> 2012-11-28 Vladimir Makarov <vmakarov@redhat.com>
>
> PR rtl-optimization/55512
> * lra-assigns.c (assign_by_spills): Assigned arbitrary hard regs
> to failed reload pseudos instead of changing asm pattern.
> * lra-constraints.c (MAX_CONSTRAINT_ITERATION_NUMBER): Increase
> value.
>
> 2012-11-28 Vladimir Makarov <vmakarov@redhat.com>
>
> PR rtl-optimization/55512
> * gcc.target/i386/pr55512-[1234].c: New tests.
Thanks, I've tweaked the tests slightly, the #define __builtin_unreachable()
was there just to put 4 different tests for 3 different ICEs into one test.
2012-11-29 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/55512
* gcc.target/i386/pr55512-2.c: Remove unnecessary define.
* gcc.target/i386/pr55512-4.c: Likewise.
--- gcc.target/i386/pr55512-2.c (revision 193922)
+++ gcc.target/i386/pr55512-2.c (revision 193923)
@@ -1,8 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-O2" } */
-#define __builtin_unreachable() do { } while (0)
-
int
foo (int x)
{
@@ -10,7 +8,6 @@ foo (int x)
"r" (x + 4), "r" (x + 5), "r" (x + 6), "r" (x + 7),
"r" (x + 8), "r" (x + 9), "r" (x + 10), "r" (x + 11),
"r" (x + 12), "r" (x + 13), "r" (x + 14), "r" (x + 15) : : lab);
- __builtin_unreachable ();
lab:
return 0;
}
--- gcc.target/i386/pr55512-4.c (revision 193922)
+++ gcc.target/i386/pr55512-4.c (revision 193923)
@@ -1,8 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-O2" } */
-#define __builtin_unreachable() do { } while (0)
-
int
bar (int x)
{
@@ -11,7 +9,6 @@ bar (int x)
"r" (x + 8), "r" (x + 9), "r" (x + 10), "r" (x + 11),
"r" (x + 12), "r" (x + 13), "r" (x + 14), "r" (x + 15),
"r" (x + 16) : : lab);
- __builtin_unreachable ();
lab:
return 0;
}
Jakub
prev parent reply other threads:[~2012-11-29 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 17:43 Vladimir Makarov
2012-11-29 8:35 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129083519.GV2315@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).