Re: [PATCH] Stream profile summary histogram through LTO files (issue6782131)

[Jan Hubicka <hubicka@ucw.cz>]

> 
> I assume you mean use the bitpack streaming functionality used other
> places in lto-cgraph.c, and not change the way it is done in gcov-io.c
> where this was cloned from? I will change the lto-cgraph.c code to use
> the bitpacking.

Yes, we don't have the facility on gcov-io, so we need to do that by hand.
> 
> >> +     lto_gcov_summary.sum_all = MAX (lto_gcov_summary.sum_all,
> >> +                                     (file_data->profile_info.sum_all
> >> +                                      * scale
> >> +                                      + REG_BR_PROB_BASE / 2)
> >> +                                     / REG_BR_PROB_BASE);
> >
> > Use RDIV for the scaling.
> 
> ok. This was cloned from the way we do other scalings in the same
> function, I will change them all to use RDIV.

Yes, thanks!
> 
> >> -#if IN_LIBGCOV || !IN_GCOV
> >> +#if !IN_GCOV
> >>  /* Determine the index into histogram for VALUE. */
> >>
> >> -static unsigned
> >> +GCOV_LINKAGE unsigned
> > I would probably go around the trouble of declaring this static in GCOV,
> > so it is inlined at we do not bload libgcov more than needed.
> 
> Do you mean leave it static when IN_LIBGCOV? It isn't included when
> IN_GCOV. I just need it extern when in the compiler. So do you mean
> make it static when IN_LIBGCOV and GCOV_LINKAGE (i.e. extern) when
> !IN_LIBGCOV?

Yes, it should help inliner to do the right things for libgcov...

Thanks,
Honza
> 
> Thanks,
> Teresa
> 
> >
> > Thanks,
> > Honza
> 
> 
> 
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413