From: Jakub Jelinek <jakub@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>
Cc: Tobias Burnus <burnus@net-b.de>, "H.J. Lu" <hjl.tools@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Add --with-build-config=bootstrap-asan support
Date: Thu, 29 Nov 2012 19:06:00 -0000 [thread overview]
Message-ID: <20121129190602.GB2315@tucnak.redhat.com> (raw)
In-Reply-To: <50B7A866.4050804@oracle.com>
On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote:
> On 11/29/2012 06:36 PM, Tobias Burnus wrote:
> >H.J. Lu wrote:
> >>This patch adds --with-build-config=bootstrap-asan support. Tested on
> >>Linux/x86-64. OK to install?
> >
> >I think that patch has broken bootstrap for me. If I do a normal
> >bootstrap, Stage1 fails with:
> >
> >libtool: compile: unrecognized option `-D_GNU_SOURCE'
> >libtool: compile: Try `libtool --help' for more information.
> >make[4]: *** [interception_linux.lo] Error 1
> >make[4]: Leaving directory `/home/burnus/gcc/build/x86_64-unknown-linux-gnu/libsanitizer/interception'
> Likewise here. Would it be possible to revert the offending commit,
> in the meanwhile?
Yes, H.J., please revert the patch, I thought you have tested it alone
without any further patches. For the -I patch, I really would prefer if
libsanitizer just had a dependency on libstdc++ at toplevel
(configure-target-sanitizer depending on all-target-libstdc++-v3),
then you can (and similarly for host variants if we need host sanitizer at
all). Then you should be able to use scripts/testsuite_flags
--build-includes just fine.
Jakub
next prev parent reply other threads:[~2012-11-29 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 20:37 H.J. Lu
2012-11-29 16:12 ` Jakub Jelinek
2012-11-29 17:36 ` Tobias Burnus
2012-11-29 17:44 ` H.J. Lu
2012-11-29 18:03 ` Tobias Burnus
2012-11-29 18:24 ` Paolo Carlini
2012-11-29 18:33 ` H.J. Lu
2012-11-29 19:04 ` H.J. Lu
2012-11-29 19:26 ` Andrew Pinski
2012-11-29 19:06 ` Jakub Jelinek [this message]
2012-11-29 20:12 ` H.J. Lu
2012-12-06 12:06 ` Markus Trippelsdorf
2012-11-29 20:46 ` H.J. Lu
2012-12-03 11:52 ` Jakub Jelinek
2012-12-03 18:02 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129190602.GB2315@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=burnus@net-b.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).