From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22862 invoked by alias); 29 Nov 2012 19:06:12 -0000 Received: (qmail 22834 invoked by uid 22791); 29 Nov 2012 19:06:10 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 19:06:06 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qATJ65Ss018084 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Nov 2012 14:06:05 -0500 Received: from zalov.redhat.com (vpn1-7-25.ams2.redhat.com [10.36.7.25]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qATJ64o9009487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 29 Nov 2012 14:06:05 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id qATJ63K9013148; Thu, 29 Nov 2012 20:06:03 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id qATJ62R8013147; Thu, 29 Nov 2012 20:06:02 +0100 Date: Thu, 29 Nov 2012 19:06:00 -0000 From: Jakub Jelinek To: Paolo Carlini Cc: Tobias Burnus , "H.J. Lu" , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Add --with-build-config=bootstrap-asan support Message-ID: <20121129190602.GB2315@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20121122203747.GA4264@gmail.com> <50B79D18.6050601@net-b.de> <50B7A866.4050804@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50B7A866.4050804@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg02494.txt.bz2 On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: > On 11/29/2012 06:36 PM, Tobias Burnus wrote: > >H.J. Lu wrote: > >>This patch adds --with-build-config=bootstrap-asan support. Tested on > >>Linux/x86-64. OK to install? > > > >I think that patch has broken bootstrap for me. If I do a normal > >bootstrap, Stage1 fails with: > > > >libtool: compile: unrecognized option `-D_GNU_SOURCE' > >libtool: compile: Try `libtool --help' for more information. > >make[4]: *** [interception_linux.lo] Error 1 > >make[4]: Leaving directory `/home/burnus/gcc/build/x86_64-unknown-linux-gnu/libsanitizer/interception' > Likewise here. Would it be possible to revert the offending commit, > in the meanwhile? Yes, H.J., please revert the patch, I thought you have tested it alone without any further patches. For the -I patch, I really would prefer if libsanitizer just had a dependency on libstdc++ at toplevel (configure-target-sanitizer depending on all-target-libstdc++-v3), then you can (and similarly for host variants if we need host sanitizer at all). Then you should be able to use scripts/testsuite_flags --build-includes just fine. Jakub