From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11519 invoked by alias); 3 Dec 2012 11:05:46 -0000 Received: (qmail 11476 invoked by uid 22791); 3 Dec 2012 11:05:44 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_LV X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Dec 2012 11:05:38 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB3B5cAD024610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Dec 2012 06:05:38 -0500 Received: from zalov.redhat.com (vpn1-5-203.ams2.redhat.com [10.36.5.203]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qB3B5ZuP014166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 3 Dec 2012 06:05:37 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id qB3B5Zqr009750; Mon, 3 Dec 2012 12:05:35 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id qB3B5YIC009749; Mon, 3 Dec 2012 12:05:34 +0100 Date: Mon, 03 Dec 2012 11:05:00 -0000 From: Jakub Jelinek To: Konstantin Serebryany Cc: Ian Lance Taylor , Dodji Seketeli , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] asan_test.cc from llvm Message-ID: <20121203110534.GS2315@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20121130101420.GE2315@tucnak.redhat.com> <20121130144602.GF2315@tucnak.redhat.com> <20121130155932.GG2315@tucnak.redhat.com> <20121130162525.GH2315@tucnak.redhat.com> <20121203091815.GP2315@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg00108.txt.bz2 On Mon, Dec 03, 2012 at 01:51:50PM +0400, Konstantin Serebryany wrote: > > I'm attaching the diff for asan_test.cc from llvm anyway. > > > >> I see #ifdef ASAN_AVOID_EXPENSIVE_TESTS, which I don't really like > >> because I'd rather fix the test than disable it. > > > > The test isn't disabled, just by default limited to 30 threads instead of > > 1000, because that really will ruin testing for everybody with ulimit -u > > in 1024-ish range. Even 500 threads would be undesirable for that. > > Which is the same as disabling it. > Unfortunately, we don't have a good automated way to test asan performance, > so this test is guarding us from performance degradation in the asan's > pthread wrappers. I understand that, that is why the test by default, when not run as part of dejagnu, or even in dejagnu when requested expensive tests, runs 1000 threads instead of 30. > Anyway, does http://llvm.org/viewvc/llvm-project?rev=169118&view=rev > solve the problem? > It adds ASAN_AVOID_EXPENSIVE_TESTS and checks the results of all > pthread_{create,join} calls in tests. Yes, thanks. So, is the patch ok to commit to GCC with the imported tests remerged from upstream (or do I need to repost the patch for that)? Jakub