From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18829 invoked by alias); 3 Dec 2012 11:52:55 -0000 Received: (qmail 18816 invoked by uid 22791); 3 Dec 2012 11:52:54 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Dec 2012 11:52:47 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB3Bqk7F016681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Dec 2012 06:52:46 -0500 Received: from zalov.redhat.com (vpn1-5-203.ams2.redhat.com [10.36.5.203]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qB3Bqis2024138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 3 Dec 2012 06:52:45 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id qB3BqhNE023636; Mon, 3 Dec 2012 12:52:43 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id qB3Bqgkh023635; Mon, 3 Dec 2012 12:52:42 +0100 Date: Mon, 03 Dec 2012 11:52:00 -0000 From: Jakub Jelinek To: "H.J. Lu" , Paolo Bonzini , Alexandre Oliva Cc: Paolo Carlini , Tobias Burnus , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Add --with-build-config=bootstrap-asan support Message-ID: <20121203115242.GU2315@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20121122203747.GA4264@gmail.com> <50B79D18.6050601@net-b.de> <50B7A866.4050804@oracle.com> <20121129190602.GB2315@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg00111.txt.bz2 Hi! On Thu, Nov 29, 2012 at 12:20:39PM -0800, H.J. Lu wrote: > On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek wrote: > > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: > >> On 11/29/2012 06:36 PM, Tobias Burnus wrote: > >> >H.J. Lu wrote: > >> >>This patch adds --with-build-config=bootstrap-asan support. Tested on > >> >>Linux/x86-64. OK to install? > >> > > >> >I think that patch has broken bootstrap for me. If I do a normal > >> >bootstrap, Stage1 fails with: > >> > > >> >libtool: compile: unrecognized option `-D_GNU_SOURCE' > >> >libtool: compile: Try `libtool --help' for more information. > >> >make[4]: *** [interception_linux.lo] Error 1 > >> >make[4]: Leaving directory `/home/burnus/gcc/build/x86_64-unknown-linux-gnu/libsanitizer/interception' > >> Likewise here. Would it be possible to revert the offending commit, > >> in the meanwhile? > > > > Yes, H.J., please revert the patch, I thought you have tested it alone > > without any further patches. For the -I patch, I really would prefer if > > libsanitizer just had a dependency on libstdc++ at toplevel > > (configure-target-sanitizer depending on all-target-libstdc++-v3), > > then you can (and similarly for host variants if we need host sanitizer at > > all). Then you should be able to use scripts/testsuite_flags > > --build-includes just fine. > > I opened: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55533 > > to explain why scripts/testsuite_flags doesn't work when > bootstrapping libsanitizer. CCing Paolo and Alex as build maintainers on this, using the script is just my preference and not sure whether it is feasible or not, though IMHO if there is a dependency on libstdc++-v3 being built before libsanitizer is configured (or perhaps just configure when it has been configured and build when it has been built), I don't see why it couldn't be used in theory. I'll defer this to them. Jakub