public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
	Jan Hubicka <hubicka@ucw.cz>,
	rguenther@suse.de, jakub@redhat.com
Subject: Re: [PATCH, PR 55078] Let indirect inlining look at ipa-cp lattices
Date: Thu, 06 Dec 2012 20:00:00 -0000	[thread overview]
Message-ID: <20121206195949.GE671@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20121206123414.GA13140@virgil.arch.suse.de>

> Hi,
> 
> the patch below re-stores a check in the inlining machinery that makes
> sure growth estimates match the reality after inlining.  However, in
> order to do that, I had to teach indirect inlining to look at IPA-CP
> data because that's what the inlining estimates do.  Even though this
> makes indirect inlining slightly more powerful, the change is not big
> and so I hope it qualifies even though we are in stage 3 now.
> 
> The patch has passed bootstrap and testing on x86_64-linux.  OK for
> trunk?
> 
> Thanks,
> 
> Martin
> 
> 
> 2012-12-05  Martin Jambor  <mjambor@suse.cz>
> 
> 	PR middle-end/55078
> 	* ipa-inline-transform.c (inline_call): Turn #if 0 to #ifdef
> 	ENABLE_CHECKING.
> 	* ipa-prop.c (try_make_edge_direct_simple_call): Use
> 	ipa_value_from_jfunc.
> 	(try_make_edge_direct_virtual_call): Likewise.
> 	(update_indirect_edges_after_inlining): Lookup new_root_info and pass
> 	it to the functions above.

The patch is OK.
I think it would make sense to have it in stage3, Richi/Jakub can you comment
from RM perspective?

Honza

  reply	other threads:[~2012-12-06 20:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06 12:34 Martin Jambor
2012-12-06 20:00 ` Jan Hubicka [this message]
2012-12-07  8:40   ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121206195949.GE671@atrey.karlin.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).