From: Jakub Jelinek <jakub@redhat.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: Jason Merrill <jason@redhat.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: C++ PATCH for c++/54325 (wrong error initializing abstract base class)
Date: Fri, 07 Dec 2012 09:17:00 -0000 [thread overview]
Message-ID: <20121207091715.GQ2315@tucnak.redhat.com> (raw)
In-Reply-To: <50C1B327.9060006@ubuntu.com>
On Fri, Dec 07, 2012 at 10:13:11AM +0100, Matthias Klose wrote:
> Am 07.12.2012 06:05, schrieb Jason Merrill:
> > It's perfectly OK to initialize a base class of abstract type; it's only an
> > error to create a full object of such a type. So this patch moves the check
> > from more generic initialization code out into a function that's definitely
> > creating a new object.
> >
> > Tested x86_64-pc-linux-gnu, applying to trunk and 4.7.
>
> this doesn't build on the branch:
>
> ../gcc/cp/tree.c: In function 'build_aggr_init_expr':
> ../gcc/cp/tree.c:399:1: error: parameter name omitted
>
> this fixes the bootstrap, currently running the testsuite.
Please commit as obvious with appropriate ChangeLog entry.
> --- cp/tree.c~ 2012-12-07 10:01:16.665415647 +0100
> +++ cp/tree.c 2012-12-07 10:11:01.373410862 +0100
> @@ -396,7 +396,8 @@
> callable. */
>
> tree
> -build_aggr_init_expr (tree type, tree init, tsubst_flags_t /*complain*/)
> +build_aggr_init_expr (tree type, tree init,
> + tsubst_flags_t complain ATTRIBUTE_UNUSED)
> {
> tree fn;
> tree slot;
Jakub
next prev parent reply other threads:[~2012-12-07 9:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 5:05 Jason Merrill
2012-12-07 9:13 ` Matthias Klose
2012-12-07 9:17 ` Jakub Jelinek [this message]
2012-12-07 9:24 ` Matthias Klose
2012-12-07 10:10 ` Paolo Carlini
2012-12-07 14:41 ` Jason Merrill
2012-12-07 13:34 ` Gabriel Dos Reis
2012-12-07 13:39 ` Jakub Jelinek
2012-12-07 13:43 ` Gabriel Dos Reis
2012-12-21 11:38 ` Paolo Carlini
2012-12-22 20:30 ` Jason Merrill
2012-12-22 23:02 ` Paolo Carlini
2012-12-24 4:56 ` Jason Merrill
2012-12-24 8:29 ` Paolo Carlini
2012-12-24 9:27 ` Paolo Carlini
2012-12-26 18:58 ` Jason Merrill
2013-01-02 20:56 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207091715.GQ2315@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=doko@ubuntu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).