From: Jakub Jelinek <jakub@redhat.com>
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] ree.c: don't abuse GTY
Date: Fri, 07 Dec 2012 10:34:00 -0000 [thread overview]
Message-ID: <20121207103441.GT2315@tucnak.redhat.com> (raw)
In-Reply-To: <CABu31nM=qP7VxX--+6WDPdk34ZvrwLuBQTwNmT67xqdavZAyQw@mail.gmail.com>
On Fri, Dec 07, 2012 at 11:25:38AM +0100, Steven Bosscher wrote:
> Perhaps somewhere during the development of ree.c struct ext_cand was
> GGC-allocated, in which case TODO_ggc_collect would make sense, to
> collect the ext_cands (there can be many of them). But since ext_cands
> are not GGC-allocated, the only garbage "produced" by ree.c is when it
> removes redundant extensions (via delete_insn). This is typically only
> a very small percentage of the instructions, so there isn't a lot of
> garbage produced.
That isn't the only garbage produced, it also updates the PATTERNs of
various instructions with something different. Have you done any
measurement on what kind of percentage of the instructions is modified,
or is "very small percentage" just a guess? E.g. on x86_64 it changes quite
a lot of instructions if I remember well. I'm not saying we can't live
without GC collection after REE, just saying it isn't at all obvious.
Jakub
next prev parent reply other threads:[~2012-12-07 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 0:06 Steven Bosscher
2012-12-07 9:08 ` Richard Biener
2012-12-07 9:43 ` Steven Bosscher
2012-12-07 9:53 ` Steven Bosscher
2012-12-07 9:58 ` Jakub Jelinek
2012-12-07 10:26 ` Steven Bosscher
2012-12-07 10:34 ` Jakub Jelinek [this message]
2012-12-07 11:36 ` Steven Bosscher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207103441.GT2315@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).