From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18869 invoked by alias); 14 Dec 2012 16:59:03 -0000 Received: (qmail 18859 invoked by uid 22791); 14 Dec 2012 16:59:02 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Dec 2012 16:58:57 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEGwv3U019433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Dec 2012 11:58:57 -0500 Received: from zalov.redhat.com (vpn1-6-211.ams2.redhat.com [10.36.6.211]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBEGws7D002740 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 14 Dec 2012 11:58:57 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id qBEGwpFD016623; Fri, 14 Dec 2012 17:58:53 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.5/8.14.5/Submit) id qBEGwmY6016622; Fri, 14 Dec 2012 17:58:48 +0100 Date: Fri, 14 Dec 2012 16:59:00 -0000 From: Jakub Jelinek To: "Iyer, Balaji V" Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH][Cilkplus] Fix pragma simd info being lost Message-ID: <20121214165843.GZ2315@tucnak.redhat.com> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg00987.txt.bz2 On Fri, Dec 14, 2012 at 04:59:02AM +0000, Iyer, Balaji V wrote: > --- tree-vect-loop.c (revision 194483) > +++ tree-vect-loop.c (working copy) > @@ -234,8 +234,8 @@ > if (flag_enable_cilk && pragma_simd_assert_requested_p > (loop->pragma_simd_index)) > { > - error ("Loop not vectorized. " > - "Exiting as requested by Pragma SIMD"); > + fatal_error ("Loop not vectorized. " > + "Exiting as requested by Pragma SIMD"); > } > return false; > } Why do you think fatal_error is the right thing here? Why doesn't normal error work? Generally, if one function contains 10 #pragma simd loops that require vectorization and 5 out of them aren't vectorized, it is nicer for users to be told about all 5 of them, rather than just the first one. fatal_error will exit immediately. Jakub