Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

[Dominique Dhumieres]

> This was fixed on trunk yesterday.

Actually I have reported it yesterday and fixed it in my tree,
but I don't have write access to SVN, so it is not fixed yet.

> The warning must be present on 4.6 and 4.7
> but doesn't cause a build error.

The error is due to the compilation with -Werror. If it is the case
for 4.6 and 4.7 it should also trigger the build error (I did not
check).

Dominique

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

On Mon, 2012-12-17 18:19:46 +0100, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> > This was fixed on trunk yesterday.
> 
> Actually I have reported it yesterday and fixed it in my tree,
> but I don't have write access to SVN, so it is not fixed yet.
> 
> > The warning must be present on 4.6 and 4.7
> > but doesn't cause a build error.
> 
> The error is due to the compilation with -Werror. If it is the case
> for 4.6 and 4.7 it should also trigger the build error (I did not
> check).

I'll commit my patch in a minute.

Actually I don't see make aborting the build (no -Werror), but I'm
having an eye on new warnings and try to fix them :)

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:               The real problem with C++ for kernel modules is:
the second  :                                 the language just sucks.
                                                   -- Linus Torvalds

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

[Dominique Dhumieres]

I have just built gcc 4.6.4 r194560 and I see the following warnings:

../../p6_work/gcc/varasm.c:2107:30: warning: 'pending_assemble_externals_set' defined but not used [-Wunused-variable]
../../p6_work/gcc/varasm.c:2112:13: warning: 'pending_assemble_externals_processed' defined but not used [-Wunused-variable]

Apparently the branches are not compiled with -Werror.

BTW thanks for the commit.

Dominique

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

On Mon, 2012-12-17 12:24:58 -0500, John David Anglin <dave.anglin@bell.net> wrote:
> On 12/17/2012 12:08 PM, John David Anglin wrote:
> > On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote:
> > > 2012-12-17  Jan-Benedict Glaw <jbglaw@lug-owl.de>
> > >
> > >    * gcc/varasm.c (pending_assemble_externals_processed): Guard
> > >    with ASM_OUTPUT_EXTERNAL.
> > This was fixed on trunk yesterday.  The warning must be present on
> > 4.6 and 4.7
> > but doesn't cause a build error.
>
> Sorry, I thought Dominique Dhumieres fixed this but I see he didn't
> apply his change.
> I would say your change is obviously ok.

Will commit.

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:         Alles wird gut! ...und heute wirds schon ein bißchen besser.
the second  :

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

[John David Anglin]

On 12/17/2012 12:08 PM, John David Anglin wrote:
> On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote:
>> 2012-12-17  Jan-Benedict Glaw <jbglaw@lug-owl.de>
>>
>>     * gcc/varasm.c (pending_assemble_externals_processed): Guard
>>     with ASM_OUTPUT_EXTERNAL.
> This was fixed on trunk yesterday.  The warning must be present on 4.6 
> and 4.7
> but doesn't cause a build error.
>
Sorry, I thought Dominique Dhumieres fixed this but I see he didn't 
apply his change.
I would say your change is obviously ok.

Dave

-- 
John David Anglin    dave.anglin@bell.net

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

On Mon, 2012-12-17 12:08:11 -0500, John David Anglin <dave.anglin@bell.net> wrote:
> On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote:
> >2012-12-17  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
> >
> >	* gcc/varasm.c (pending_assemble_externals_processed): Guard
> >	with ASM_OUTPUT_EXTERNAL.
> This was fixed on trunk yesterday.  The warning must be present on

Great. Takes a day until I'm up with my build robot...

Thanks, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of: "Debugging is twice as hard as writing the code in the first place.
the second  :  Therefore, if you write the code as cleverly as possible, you are,
               by definition, not smart enough to debug it." - Brian W. Kernighan

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

[John David Anglin]

On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote:
> 2012-12-17  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
>
> 	* gcc/varasm.c (pending_assemble_externals_processed): Guard
> 	with ASM_OUTPUT_EXTERNAL.
This was fixed on trunk yesterday.  The warning must be present on 4.6 
and 4.7
but doesn't cause a build error.

Thanks,
Dave

-- 
John David Anglin    dave.anglin@bell.net

[PATCH] Fix recent warning about pending_assemble_externals_processed

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]

Hi!

I'd like to apply the following patch to fix a warning:

../../../../gcc/gcc/varasm.c:2094:13: warning: ‘pending_assemble_externals_processed’ defined but not used [-Wunused-variable]

(seen on microblaze-uclinux and pdp11-aout) introduced with a fix for
PR middle-end/55709 and 52894:

+2012-12-16  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>
+
+       PR middle-end/55709
+       Forward port from 4.7 branch:
+       2012-04-10  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>
+
+       PR middle-end/52894
+       * varasm.c (process_pending_assemble_externals): Set
+       pending_assemble_externals_processed true.
+       (assemble_external): Call assemble_external_real if the pending
+       assemble externals have been processed.

Okay to commit?



2012-12-17  Jan-Benedict Glaw  <jbglaw@lug-owl.de>

	* gcc/varasm.c (pending_assemble_externals_processed): Guard
	with ASM_OUTPUT_EXTERNAL.

diff --git a/gcc/varasm.c b/gcc/varasm.c
index daeb6e2..53ebfbf 100644
--- a/gcc/varasm.c
+++ b/gcc/varasm.c
@@ -2088,12 +2088,12 @@ contains_pointers_p (tree type)
    it all the way to final.  See PR 17982 for further discussion.  */
 static GTY(()) tree pending_assemble_externals;
 
+#ifdef ASM_OUTPUT_EXTERNAL
 /* Some targets delay some output to final using TARGET_ASM_FILE_END.
    As a result, assemble_external can be called after the list of externals
    is processed and the pointer set destroyed.  */
 static bool pending_assemble_externals_processed;
 
-#ifdef ASM_OUTPUT_EXTERNAL
 /* Avoid O(external_decls**2) lookups in the pending_assemble_externals
    TREE_LIST in assemble_external.  */
 static struct pointer_set_t *pending_assemble_externals_set;



-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:          GDB has a 'break' feature; why doesn't it have 'fix' too?
the second  :

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]