* [asan] Use -fno-shrink-wrap for null-deref-1.c test
@ 2012-12-19 12:13 Jakub Jelinek
2013-01-08 7:52 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2012-12-19 12:13 UTC (permalink / raw)
To: Konstantin Serebryany, Dmitry Vyukov, Dodji Seketeli; +Cc: gcc-patches
Hi!
Weirdly this test fails just on some boxes and others succeeds
(x86_64-linux, -Os only). The problem seems to be in the libasan fast
unwinder, if the routine is shrink-wrapped, even when it is compiled with
-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer, if the memory
dereference which is supposed to segfault is outside of the region with
valid frame pointer, the backtrace will still be wrong.
Hopefully fixed by adding -fno-shrink-wrap.
2012-12-19 Jakub Jelinek <jakub@redhat.com>
* c-c++-common/asan/null-deref-1.c: Add -fno-shrink-wrap to
dg-options.
--- gcc/testsuite/c-c++-common/asan/null-deref-1.c.jj 2012-12-13 00:02:50.000000000 +0100
+++ gcc/testsuite/c-c++-common/asan/null-deref-1.c 2012-12-19 12:30:05.354962160 +0100
@@ -1,5 +1,5 @@
/* { dg-do run } */
-/* { dg-options "-fno-omit-frame-pointer" } */
+/* { dg-options "-fno-omit-frame-pointer -fno-shrink-wrap" } */
/* { dg-additional-options "-mno-omit-leaf-frame-pointer" { target { i?86-*-* x86_64-*-* } } } */
/* { dg-shouldfail "asan" } */
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [asan] Use -fno-shrink-wrap for null-deref-1.c test
2012-12-19 12:13 [asan] Use -fno-shrink-wrap for null-deref-1.c test Jakub Jelinek
@ 2013-01-08 7:52 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2013-01-08 7:52 UTC (permalink / raw)
To: Jakub Jelinek
Cc: Konstantin Serebryany, Dmitry Vyukov, Dodji Seketeli, gcc-patches
Jakub Jelinek <jakub@redhat.com> writes:
> 2012-12-19 Jakub Jelinek <jakub@redhat.com>
>
> * c-c++-common/asan/null-deref-1.c: Add -fno-shrink-wrap to
> dg-options.
This looks OK to me, thanks.
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-08 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-19 12:13 [asan] Use -fno-shrink-wrap for null-deref-1.c test Jakub Jelinek
2013-01-08 7:52 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).