From: Jakub Jelinek <jakub@redhat.com>
To: Mike Stump <mikestump@comcast.net>
Cc: "gcc-patches@gcc.gnu.org Patches" <gcc-patches@gcc.gnu.org>,
Diego Novillo <dnovillo@google.com>
Subject: Re: unnecessary assert
Date: Wed, 09 Jan 2013 23:51:00 -0000 [thread overview]
Message-ID: <20130109235049.GT7269@tucnak.redhat.com> (raw)
In-Reply-To: <55327D81-C743-4A22-890C-3FD6AC859577@comcast.net>
On Wed, Jan 09, 2013 at 02:57:00PM -0800, Mike Stump wrote:
> Ok for 2.8?
Not to 2.8, but to 4.8 it is ok.
> http://gcc.gnu.org/PR31150 is the PR when the assert was added, if you want to see it. svn+ssh://gcc.gnu.org/svn/gcc/trunk@142892 is the change itself.
That actually didn't add the assert, just moved it from lots lines later
(unconditional there) to the conditional spot here.
> 2013-01-09 Mike Stump <mikestump@comcast.net>
>
> * dse.c (record_store): Remove unnecessary assert.
>
> 2013-01-09 Mike Stump <mikestump@comcast.net>
>
> * dse.c (record_store): Remove unnecessary assert.
>
> --- dse.c (revision 195067)
> +++ dse.c (working copy)
> @@ -1495,10 +1495,7 @@ record_store (rtx body, bb_info_t bb_inf
> if (GET_MODE (mem) == BLKmode)
> width = MEM_SIZE (mem);
> else
> - {
> - width = GET_MODE_SIZE (GET_MODE (mem));
> - gcc_assert ((unsigned) width <= HOST_BITS_PER_WIDE_INT);
> - }
> + width = GET_MODE_SIZE (GET_MODE (mem));
>
> if (spill_alias_set)
> {
Jakub
prev parent reply other threads:[~2013-01-09 23:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 22:57 Mike Stump
2013-01-09 23:51 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109235049.GT7269@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).