From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5297 invoked by alias); 9 Jan 2013 23:51:00 -0000 Received: (qmail 5289 invoked by uid 22791); 9 Jan 2013 23:50:59 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Jan 2013 23:50:54 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r09Noq5A004651 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Jan 2013 18:50:53 -0500 Received: from zalov.redhat.com (vpn1-5-134.ams2.redhat.com [10.36.5.134]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r09NooEX009296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 9 Jan 2013 18:50:52 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id r09NoodX018889; Thu, 10 Jan 2013 00:50:50 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r09Non32018888; Thu, 10 Jan 2013 00:50:49 +0100 Date: Wed, 09 Jan 2013 23:51:00 -0000 From: Jakub Jelinek To: Mike Stump Cc: "gcc-patches@gcc.gnu.org Patches" , Diego Novillo Subject: Re: unnecessary assert Message-ID: <20130109235049.GT7269@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <55327D81-C743-4A22-890C-3FD6AC859577@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55327D81-C743-4A22-890C-3FD6AC859577@comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00511.txt.bz2 On Wed, Jan 09, 2013 at 02:57:00PM -0800, Mike Stump wrote: > Ok for 2.8? Not to 2.8, but to 4.8 it is ok. > http://gcc.gnu.org/PR31150 is the PR when the assert was added, if you want to see it. svn+ssh://gcc.gnu.org/svn/gcc/trunk@142892 is the change itself. That actually didn't add the assert, just moved it from lots lines later (unconditional there) to the conditional spot here. > 2013-01-09 Mike Stump > > * dse.c (record_store): Remove unnecessary assert. > > 2013-01-09 Mike Stump > > * dse.c (record_store): Remove unnecessary assert. > > --- dse.c (revision 195067) > +++ dse.c (working copy) > @@ -1495,10 +1495,7 @@ record_store (rtx body, bb_info_t bb_inf > if (GET_MODE (mem) == BLKmode) > width = MEM_SIZE (mem); > else > - { > - width = GET_MODE_SIZE (GET_MODE (mem)); > - gcc_assert ((unsigned) width <= HOST_BITS_PER_WIDE_INT); > - } > + width = GET_MODE_SIZE (GET_MODE (mem)); > > if (spill_alias_set) > { Jakub