From: Jakub Jelinek <jakub@redhat.com>
To: Konstantin Serebryany <konstantin.s.serebryany@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Dodji Seketeli <dodji@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
Wei Mi <wmi@google.com>
Subject: Re: libsanitizer mege from upstream r171973
Date: Thu, 10 Jan 2013 11:31:00 -0000 [thread overview]
Message-ID: <20130110113008.GW7269@tucnak.redhat.com> (raw)
In-Reply-To: <CAGQ9bdzaeqSw=1q1gDX_3PP9M_jX65Zy62_mB-cfoyJ1vaP8sg@mail.gmail.com>
On Thu, Jan 10, 2013 at 03:27:41PM +0400, Konstantin Serebryany wrote:
> > So, I'd guard the prctl call with additional
> > #ifdef PR_SET_NAME
>
> Ok.
> I'd prefer to guard the whole test with #if defined(__linux__) &&
> defined(PR_SET_NAME).
That is not sufficient. You can have PR_SET_NAME defined in the headers,
but still the underlying kernel doesn't need to handle it.
> It is very likely that I will flip fast_unwind_on_fatal to 0 next week.
Perfect, thanks.
Jakub
next prev parent reply other threads:[~2013-01-10 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 7:01 Konstantin Serebryany
[not found] ` <CAGQ9bdzbtJ3Fh1QzgqzOvMaxzm98ZnyjORk+wU46Kbi0KWwCyA@mail.gmail.com>
2013-01-10 7:08 ` Konstantin Serebryany
2013-01-10 10:59 ` Jakub Jelinek
2013-01-10 11:28 ` Konstantin Serebryany
2013-01-10 11:31 ` Jakub Jelinek [this message]
2013-01-10 11:58 ` Konstantin Serebryany
2013-01-10 12:23 ` Jakub Jelinek
2013-01-10 12:28 ` Konstantin Serebryany
2013-01-10 7:09 ` Dmitry Vyukov
2013-01-10 15:38 ` Jack Howarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110113008.GW7269@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=dodji@redhat.com \
--cc=dvyukov@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=konstantin.s.serebryany@gmail.com \
--cc=wmi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).