public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Zdenek Dvorak <rakdver@iuuk.mff.cuni.cz>
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: Marek Polacek <polacek@redhat.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	Richard Guenther <rguenther@suse.de>
Subject: Re: [PATCH] Fix PR55833 + cheaper checking
Date: Thu, 10 Jan 2013 22:20:00 -0000	[thread overview]
Message-ID: <20130110221943.GA14720@kam.mff.cuni.cz> (raw)
In-Reply-To: <CABu31nM32xKY3gj4PXYC5X12WhJ8iCpbyxWz=ptED54UTNNVZg@mail.gmail.com>

Hi,

> On Thu, Jan 10, 2013 at 6:31 PM, Marek Polacek wrote:
> > +  /* We changed the CFG.  Recompute irreducible BBs and edges.  */
> > +  mark_irreducible_loops ();
> 
> This is a very expensive fix for a really unusual situation.
> 
> I don't think this is the right thing to do...

I agree -- at the very least, unswitch_single_loop should check whether there
is any possiblity it could have affected irreducible loops information (this
should only be the case when some already existing irreducible loop is altered
in the progress).  Which is what it (or more precisely, remove_path function
used by it) tries to do -- so is should be sufficient to check why this fails
for the considered testcase, and make sure the situation is correctly detected,

Zdenek

  reply	other threads:[~2013-01-10 22:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 17:31 Marek Polacek
2013-01-10 17:42 ` Steven Bosscher
2013-01-10 22:20   ` Zdenek Dvorak [this message]
2013-01-14 16:14     ` Marek Polacek
2013-01-14 17:52       ` Zdenek Dvorak
2013-01-14 19:11         ` Marek Polacek
2013-01-15 22:22           ` Zdenek Dvorak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130110221943.GA14720@kam.mff.cuni.cz \
    --to=rakdver@iuuk.mff.cuni.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=polacek@redhat.com \
    --cc=rguenther@suse.de \
    --cc=stevenb.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).