From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20245 invoked by alias); 13 Jan 2013 22:13:05 -0000 Received: (qmail 20236 invoked by uid 22791); 13 Jan 2013 22:13:05 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from one.firstfloor.org (HELO one.firstfloor.org) (213.235.205.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 13 Jan 2013 22:12:52 +0000 Received: by one.firstfloor.org (Postfix, from userid 503) id A6AF31A9806F; Sun, 13 Jan 2013 23:12:51 +0100 (CET) Date: Sun, 13 Jan 2013 22:13:00 -0000 From: Andi Kleen To: Uros Bizjak Cc: Andi Kleen , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/2] Support __ATOMIC_HLE_RELEASE for __atomic_clear/store_n Message-ID: <20130113221251.GW30577@one.firstfloor.org> References: <20130113203603.GS30577@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00665.txt.bz2 > >> +(define_insn "atomic_store_1" > >> + [(set (match_operand:ATOMIC 0 "memory_operand" "=m") > >> + (unspec:ATOMIC [(match_operand:ATOMIC 1 "" "") > >> + (match_operand:SI 2 "const_int_operand")] > >> + UNSPEC_MOVA))] > >> + "" > >> + "%K2mov{}\t{%1, %0|%0, %1}") > > > > Is that the updated pattern you wanted? It looks similar to mine. > > Yes the attached patch actually implements all proposed fixes. Ok great. Can you just commit it then? It looks good to me. -Andi -- ak@linux.intel.com -- Speaking for myself only.